Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch file for running gzserver #532

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Apr 12, 2024

馃帀 New feature

Summary

This patch allows to run gzserver as an executable or as a composable node.

How to test it?

Use the provided gz_server.launch.py to run gzserver as an executable:

ros2 launch ros_gz_sim gz_server.launch.py world_sdf_file:=empty.sdf

Confirm that you see gzserver loading and verify that no container has been created:

caguero@cold:~/ros_gz_ws$ ros2 component list

Now CTRL-C gzserver and try the composable version:

ros2 launch ros_gz_sim gz_server.launch.py world_sdf_file:=empty.sdf use_composition:=True

Confirm that you see gzserver loading and verify that a new container has been created:

caguero@cold:~/ros_gz_ws$ ros2 component list
/ros_gz_container
  1  /gzserver

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Ag眉ero <caguero@openrobotics.org>
Signed-off-by: Carlos Ag眉ero <caguero@openrobotics.org>
Signed-off-by: Carlos Ag眉ero <caguero@openrobotics.org>
Signed-off-by: Carlos Ag眉ero <caguero@openrobotics.org>
@caguero caguero requested a review from ahcorde as a code owner April 12, 2024 16:55
Signed-off-by: Carlos Ag眉ero <caguero@openrobotics.org>
@@ -0,0 +1,92 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed 5f6c44d.

Signed-off-by: Carlos Ag眉ero <caguero@openrobotics.org>
@caguero caguero merged commit 78127ca into gz_sim_ros_node_composition Apr 18, 2024
5 checks passed
@caguero caguero deleted the gzserver_launch branch April 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants