Renamed Ignition and ign to Gazebo or gz #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
This was referenced Sep 21, 2022
This was referenced Sep 21, 2022
azeey
requested changes
Sep 21, 2022
quickstart/tutorial_2-0.md
Outdated
| @@ -154,7 +154,7 @@ std::cout << "Joint " << jointName << " connects " << parentLinkName | |||
|
|
|||
| ``` | |||
|
|
|||
| As you might guess, we're getting the `name` attribute of the current `joint_element` and then retrieving its `parent` and `child` elements' values. It is interesting to note all `Get()` method's use cases: `Get()` is a template method that returns the given attribute value or the element value itself (that is, the plain text in between tags) if called with no arguments. To this end, it has been specialized to parse such value accordingly into primitive types (i.e. `double`), common std types (i.e. `std::string`) or [`ignition::math`](http://ignitionrobotics.org/libraries/math) types for the most complex ones (like poses). | |||
| As you might guess, we're getting the `name` attribute of the current `joint_element` and then retrieving its `parent` and `child` elements' values. It is interesting to note all `Get()` method's use cases: `Get()` is a template method that returns the given attribute value or the element value itself (that is, the plain text in between tags) if called with no arguments. To this end, it has been specialized to parse such value accordingly into primitive types (i.e. `double`), common std types (i.e. `std::string`) or [`gazebo::math`](http://gazebosim.org/libraries/math) types for the most complex ones (like poses). | |||
There was a problem hiding this comment.
Since this is for an earlier version of libsdformat, having ignition::math might make more sense.
python_example.py
Outdated
| @@ -0,0 +1,68 @@ | |||
|
|
|||
| from gz.math7 import Vector3d | |||
There was a problem hiding this comment.
Was this file added intentionally? It doesn't seem relevant to the PR
install/tutorial_9_later.md
Outdated
|
|
||
| You can view lists of dependencies: | ||
|
|
||
| conda search libsdformat --channel conda-forge --info | ||
|
|
||
| Install dependencies, replacing `<#>` with the desired versions: | ||
|
|
||
| conda install libignition-math<#> libignition-tools<#> --channel conda-forge | ||
| conda install libgz-math<#> libgz-tools<#> --channel conda-forge |
There was a problem hiding this comment.
There is currently no libgz-math<#> package on conda.
install/tutorial_12.md
Outdated
|
|
||
| You can view lists of dependencies: | ||
|
|
||
| conda search libsdformat --channel conda-forge --info | ||
|
|
||
| Install dependencies, replacing `<#>` with the desired versions: | ||
|
|
||
| conda install libignition-math<#> libignition-tools<#> --channel conda-forge | ||
| conda install libgz-math<#> libgz-tools<#> --channel conda-forge |
There was a problem hiding this comment.
There is no libgz-math<#> package on conda.
There was a problem hiding this comment.
There is now: https://github.com/conda-forge/gz-math-feedstock .
1 similar comment
azeey
reviewed
Oct 26, 2022
azeey
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
馃 Bug fix
Summary
Related with
Renamed Ignition and ign to Gazebo or gz.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.