Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignition -> Gazebo #1080

Merged
merged 2 commits into from
Jul 16, 2022
Merged

Ignition -> Gazebo #1080

merged 2 commits into from
Jul 16, 2022

Conversation

jennuine
Copy link
Collaborator

🦟 Bug fix

Part of:

Summary

Updated links, naming, and added badges to match the other Gazebo libraries in README.md

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine added the QA Quality assurance. label Jul 15, 2022
@jennuine jennuine requested a review from chapulina July 15, 2022 22:04
@jennuine jennuine requested a review from azeey as a code owner July 15, 2022 22:04
@jennuine jennuine self-assigned this Jul 15, 2022
@jennuine jennuine requested a review from scpeters as a code owner July 15, 2022 22:04
@osrf-triage osrf-triage added this to Inbox in Core development Jul 15, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1080 (cd6fbfd) into sdf9 (2f13983) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             sdf9    #1080   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          64       64           
  Lines       10061    10061           
=======================================
  Hits         8813     8813           
  Misses       1248     1248           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f13983...cd6fbfd. Read the comment docs.

Core development automation moved this from Inbox to In review Jul 16, 2022
@scpeters scpeters merged commit e9e9546 into sdf9 Jul 16, 2022
Core development automation moved this from In review to Done Jul 16, 2022
@scpeters scpeters deleted the jennuine/readme_updates branch July 16, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 QA Quality assurance.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants