Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor: add sdf::Errors output to API methods #1138

Merged
merged 5 commits into from
Dec 9, 2022

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Sep 12, 2022

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🎉 New feature

Work towards #820.

Summary

Makes errors to be reported through sdf::Errors when using the ToElement(sdf::Errors &_errors) method of the Sensor class.

Test it

Using the ToElement(sdf::Errors &_errors) method of the Sensor class should report all errors through sdf::Errors.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1138 (135da9e) into sdf13 (74b5785) will decrease coverage by 0.00%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##            sdf13    #1138      +/-   ##
==========================================
- Coverage   87.20%   87.20%   -0.01%     
==========================================
  Files         124      124              
  Lines       16222    16229       +7     
==========================================
+ Hits        14146    14152       +6     
- Misses       2076     2077       +1     
Impacted Files Coverage Δ
src/Sensor.cc 92.92% <91.66%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters moved this from Inbox to In review in Core development Sep 19, 2022
Marco A. Gutierrez added 2 commits October 3, 2022 09:50
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@marcoag marcoag changed the base branch from main to sdf13 October 3, 2022 09:54
@azeey azeey moved this from In review to In progress in Core development Nov 10, 2022
Core development automation moved this from In progress to In review Dec 8, 2022
@marcoag marcoag merged commit cd08bd4 into sdf13 Dec 9, 2022
Core development automation moved this from In review to Done Dec 9, 2022
@marcoag marcoag deleted the marcoag/sdf_error_sensor branch December 9, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants