Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm tests #1173

Merged
merged 4 commits into from
Sep 27, 2022
Merged

Fix arm tests #1173

merged 4 commits into from
Sep 27, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 27, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🦟 Bug fix

Summary

Fixes the arm tests. See https://build.osrfoundation.org/job/sdformat13-debbuilder/589/consoleFull#-2388225956ea37b8d-a6d4-40ae-8431-d90c018842af.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 27, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Sep 27, 2022
@scpeters
Copy link
Member

scpeters commented Sep 27, 2022

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1173 (b0f942c) into sdf13 (b5291c4) will not change coverage.
The diff coverage is n/a.

❗ Current head b0f942c differs from pull request most recent head fd9cc1b. Consider uploading reports for the commit fd9cc1b to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1173   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files         125      125           
  Lines       15834    15834           
=======================================
  Hits        13777    13777           
  Misses       2057     2057           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Nate Koenig added 3 commits September 27, 2022 12:31
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Core development automation moved this from Inbox to In review Sep 27, 2022
@scpeters scpeters merged commit 06912cb into sdf13 Sep 27, 2022
@scpeters scpeters deleted the fix_arm_tests branch September 27, 2022 22:09
Core development automation moved this from In review to Done Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants