-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn child joint that resolves to world #1211
Conversation
…it hasn't been implemented yet Signed-off-by: Liam Han <liamhan0905@gmail.com>
Signed-off-by: Liam Han <liamhan0905@gmail.com>
Signed-off-by: Liam Han <liamhan0905@gmail.com>
@azeey now that I think about it, maybe this can be much simpler...
I'm going to make the necessary changes and push again. I think it'll be much cleaner. Feel free to check out the previous commits and let me know your thoughts |
Signed-off-by: Liam Han <liamhan0905@gmail.com>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1211 +/- ##
=======================================
Coverage 87.19% 87.20%
=======================================
Files 124 124
Lines 16218 16222 +4
=======================================
+ Hits 14142 14146 +4
Misses 2076 2076
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! And props on realizing that we don't need another test.
/cc @scpeters
good call; I guess I had made the test but didn't add all the checking logic. It would have been more obvious if I had split the error cases into separate files, but I was lazy. Nice job catching it! |
Summary
SDFormat doesn't allow
The latter is implemented in this PR
I originally created a new test with a example sdf. However, after pushing the code, I realized that there's actually a very similar TEST that checks for the same thing. Therefore the latest push cleans up all the unnecessary noise.
Test it
The first commit only contains the test so it doesn't catch when the resolved child link is the world. Therefore, it'll result in a FAIL test. But the second commit contains the logic to catch when the resolved child link is the world. Hence the test will PASScheckout1390e88f550a5a40329b433b1f2324c721b2bb9b
commit and rebuild. Run thegazebo_garden/build/sdformat13/bin/INTEGRATION_joint_dom
test. This should result in one test that FAILS.checkout58319f00e436bd82263de6767b269cb3d3815a17
commit and rebuild. Run the test again and this time, the test will PASS.Checklist
codecheck
passed (See contributing)