Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sdf9 ➡️ sdf12 #1224

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Merge sdf9 ➡️ sdf12 #1224

merged 4 commits into from
Feb 1, 2023

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port sdf9 ➡️ sdf12

Branch comparison: sdf12...sdf9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

voxik and others added 2 commits January 25, 2023 20:24
`File.exists?` has been deprecated and is now removed in Ruby 3.2. 

https://github.com/ruby/ruby/blob/a528908271c678360d2d8ca232c178e7cdd340b4/NEWS.md?plain=1#L58

Signed-off-by: Vít Ondruch <vondruch@redhat.com>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
@scpeters scpeters requested a review from azeey as a code owner January 30, 2023 19:04
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 30, 2023
@osrf-triage osrf-triage added this to Inbox in Core development Jan 30, 2023
@scpeters scpeters moved this from Inbox to In review in Core development Jan 30, 2023
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #1224 (94fd487) into sdf12 (8ed9764) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            sdf12    #1224   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          79       79           
  Lines       13090    13090           
=======================================
  Hits        12046    12046           
  Misses       1044     1044           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit d9bc9c6 into sdf12 Feb 1, 2023
Core development automation moved this from In review to Done Feb 1, 2023
@scpeters scpeters deleted the scpeters/merge_9_12 branch February 1, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants