Fix Element Set method return value

[marcoag]

🦟 Bug fix

Summary

Discovered here, the Element Set method would return true ignoring the result coming from the this->dataPtr->value->Set(_value);. This could cause the Set method to sometimes error but still return true.

This PR fixes it and it makes the method return the result of this->dataPtr->value->Set(_value); instead of the hardcoded true.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (sdf9@11ad259). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ddc7126 differs from pull request most recent head 9b196ce. Consider uploading reports for the commit 9b196ce to get more accurate results

@@           Coverage Diff           @@
##             sdf9    #1256   +/-   ##
=======================================
  Coverage        ?   88.35%           
=======================================
  Files           ?       63           
  Lines           ?    10092           
  Branches        ?        0           
=======================================
  Hits            ?     8917           
  Misses          ?     1175           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[azeey]

@scpeters Do you think this is safe for Gazebo-classic?

[scpeters]

@scpeters Do you think this is safe for Gazebo-classic?

I looked and I don't see a single place where the return value of Element::Set is checked. So that's maybe concerning on its own, but it means that this pull request shouldn't affect gazebo-classic. Thanks for checking

[marcoag]

@osrf-jenkins run tests please