-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Element Set method return value #1256
Conversation
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf9 #1256 +/- ##
=======================================
Coverage ? 88.35%
=======================================
Files ? 63
Lines ? 10092
Branches ? 0
=======================================
Hits ? 8917
Misses ? 1175
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@scpeters Do you think this is safe for Gazebo-classic? |
I looked and I don't see a single place where the return value of |
@osrf-jenkins run tests please |
🦟 Bug fix
Summary
Discovered here, the Element Set method would
return true
ignoring the result coming from thethis->dataPtr->value->Set(_value);
. This could cause the Set method to sometimes error but still returntrue
.This PR fixes it and it makes the method return the result of
this->dataPtr->value->Set(_value);
instead of the hardcodedtrue
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.