Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing values in Surace ToElement method #1263

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Mar 27, 2023

🦟 Bug fix

Summary

This PR adds the transfer of missing attributes in the ToElement() method of the Surface class. It also adds a test for it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1263 (963e5d7) into sdf12 (6ffe669) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            sdf12    #1263   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          79       79           
  Lines       13120    13127    +7     
=======================================
+ Hits        12089    12096    +7     
  Misses       1031     1031           
Impacted Files Coverage Δ
src/Surface.cc 88.32% <100.00%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey moved this from Inbox to In review in Core development Mar 27, 2023
@marcoag marcoag requested review from aaronchongth and removed request for aaronchongth March 29, 2023 06:58
@marcoag marcoag changed the title Add values misisng in Surace ToElement method Add values missing in Surace ToElement method Mar 29, 2023
@marcoag marcoag changed the title Add values missing in Surace ToElement method Add missing values in Surace ToElement method Mar 30, 2023
@marcoag marcoag merged commit 849be12 into sdf12 Mar 30, 2023
Core development automation moved this from In review to Done Mar 30, 2023
@marcoag marcoag deleted the marcoag/fix_surface_toelement branch March 30, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants