-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bullet and torsional friction DOM #1351
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sdf12 #1351 +/- ##
==========================================
+ Coverage 92.14% 92.16% +0.01%
==========================================
Files 79 79
Lines 13126 13260 +134
==========================================
+ Hits 12095 12221 +126
- Misses 1031 1039 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@ahcorde mind taking another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments, otherwise LGTM
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one more change in 534164b that renames the Side note, there is also the proposal in #508 to change the way physics engine params are specified, which would affect these DOM classes in the future. |
should be fixed. 4ca98b5 |
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
🎉 New feature
Summary
Add Bullet, Torsional friction DOM classes
Test it
Run the
UNIT_Surface_TEST
andINTEGRATION_surface_dom
testsChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.