Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bullet and torsional friction DOM #1351

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Add bullet and torsional friction DOM #1351

merged 9 commits into from
Mar 20, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 8, 2023

🎉 New feature

Summary

Add Bullet, Torsional friction DOM classes

Test it

Run the UNIT_Surface_TEST and INTEGRATION_surface_dom tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 8, 2023
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: Patch coverage is 94.02985% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 92.16%. Comparing base (5fab7a4) to head (4ca98b5).
Report is 1 commits behind head on sdf12.

Files Patch % Lines
src/Surface.cc 94.02% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            sdf12    #1351      +/-   ##
==========================================
+ Coverage   92.14%   92.16%   +0.01%     
==========================================
  Files          79       79              
  Lines       13126    13260     +134     
==========================================
+ Hits        12095    12221     +126     
- Misses       1031     1039       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/sdf/Surface.hh Show resolved Hide resolved
src/Surface_TEST.cc Outdated Show resolved Hide resolved
@azeey azeey requested a review from ahcorde March 11, 2024 16:58
@azeey
Copy link
Collaborator

azeey commented Mar 18, 2024

@ahcorde mind taking another look

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments, otherwise LGTM

src/Surface.cc Outdated Show resolved Hide resolved
src/Surface.cc Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iche033
Copy link
Contributor Author

iche033 commented Mar 20, 2024

I added one more change in 534164b that renames the sdf::Bullet class to sdf::BulletFriction to avoid conflicting with other <bullet> sdf elements in the sdf spec that potentially may have its own DOM classes.

Side note, there is also the proposal in #508 to change the way physics engine params are specified, which would affect these DOM classes in the future.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Mar 20, 2024

@ahcorde ahcorde merged commit 9101e86 into sdf12 Mar 20, 2024
14 checks passed
@ahcorde ahcorde deleted the more_friction_dom branch March 20, 2024 08:58
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants