Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom attribute to custom element in test #1406

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Confirms that #54 has been fixed

Summary

Issue #54 was opened before we had documented support for custom elements and attributes and mentions that custom attributes are not supported within a custom element. This was fixed at some point (not sure when), and I have confirmed this by adding a custom attribute inside a custom element in the test/integration/custom_elems_attrs.sdf file and updated the associated expectations in the INTEGRATION_sdf_custom test.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Update test to confirm that #54 is fixed.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (ff9b3ad) to head (a9024fa).
Report is 33 commits behind head on sdf14.

Additional details and impacted files
@@            Coverage Diff             @@
##            sdf14    #1406      +/-   ##
==========================================
+ Coverage   92.42%   92.48%   +0.05%     
==========================================
  Files         134      135       +1     
  Lines       17751    18072     +321     
==========================================
+ Hits        16406    16713     +307     
- Misses       1345     1359      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scpeters scpeters merged commit 44cc342 into sdf14 Jun 19, 2024
13 checks passed
@scpeters scpeters deleted the scpeters/custom_attribute_in_custom_element branch June 19, 2024 04:33
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Update test to confirm that gazebosim#54 is fixed.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Update test to confirm that gazebosim#54 is fixed.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants