-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Backport) Enable 24.04 CI, remove distutils dependency (#1408) #1413
Conversation
* distutils is no longer required since this branch requires a new enough version of cmake. * Remove outdated cmake code: setting python debug libraries is not needed as of cmake 3.12. * Require cmake 3.22.1 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sdf14 #1413 +/- ##
==========================================
+ Coverage 92.42% 92.44% +0.01%
==========================================
Files 134 135 +1
Lines 17751 17837 +86
==========================================
+ Hits 16406 16489 +83
- Misses 1345 1348 +3 ☔ View full report in Codecov by Sentry. |
@scpeters ABI checker is failing on the CMake version :/ |
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
I think this is a problem with infra and not this PR; let's try to fix the infra |
python/CMakeLists.txt
Outdated
if(USE_SYSTEM_PATHS_FOR_PYTHON_INSTALLATION) | ||
if(${CMAKE_VERSION} VERSION_LESS "3.12.0") | ||
execute_process( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should revert this. We can be sure Jammy has CMake > 3.12, but since the whole project sets the minimum version to 3.10, we can't assume that this is being built by a newer version of CMake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes related to CMakeLists were removed in 47e82ba
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
* Enable 24.04 CI, remove distutils dependency (gazebosim#1408) distutils is no longer required since this branch requires a new enough version of cmake. Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Enable 24.04 CI, remove distutils dependency (gazebosim#1408) distutils is no longer required since this branch requires a new enough version of cmake. Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
🦟 Bug fix
Should fix CI on sdformat for Harmonic.
See reference job: https://build.osrfoundation.org/job/sdformat-ci-sdf14-noble-amd64/
Summary
Backporting the removal of the distutils dependency
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.