Prefix nested model names when flattening #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the addNestedModel function in parser.cc prefixes link, joint, and frame names with the flattened model name delimited by "::". This applies the same prefix to the names of nested models within the flattened model as well. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added this to In progress
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
via automation
Codecov Report
@@ Coverage Diff @@
## sdf10 #399 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 60 60
Lines 9219 9220 +1
=======================================
+ Hits 8054 8055 +1
Misses 1165 1165
Continue to review full report at Codecov.
|
scpeters
moved this from In progress
to In Review
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
There was a problem hiding this comment.
Looking
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @azeey)
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @azeey)
azeey
approved these changes
Oct 30, 2020
SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
automation
moved this from In Review
to Done
Oct 30, 2020
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Oct 30, 2020
Currently the addNestedModel function in parser.cc prefixes link, joint, and frame names with the flattened model name delimited by "::". This applies the same prefix to the names of nested models within the flattened model as well. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Oct 30, 2020
Currently the addNestedModel function in parser.cc prefixes link, joint, and frame names with the flattened model name delimited by "::". This applies the same prefix to the names of nested models within the flattened model as well. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Oct 30, 2020
Currently the addNestedModel function in parser.cc prefixes link, joint, and frame names with the flattened model name delimited by "::". This applies the same prefix to the names of nested models within the flattened model as well. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
I can't remember if we wanted to backport this to sdf9? |
|
I can't remember either :( @azeey If there is a plan to release and incorporate a new |
azeey
pushed a commit
to azeey/sdformat
that referenced
this pull request
Nov 24, 2020
Currently the addNestedModel function in parser.cc prefixes link, joint, and frame names with the flattened model name delimited by "::". This applies the same prefix to the names of nested models within the flattened model as well. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey
pushed a commit
that referenced
this pull request
Nov 25, 2020
Currently the addNestedModel function in parser.cc prefixes link, joint, and frame names with the flattened model name delimited by "::". This applies the same prefix to the names of nested models within the flattened model as well. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
nkoenig
removed this from Done
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the addNestedModel function in parser.cc prefixes link, joint, and frame names with the flattened model name delimited by "::". This applies the same prefix to the names of nested models within the flattened model as well. Motivated by #355 (review)