-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/include pose degrees #697
Conversation
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
ae3344e
to
e442725
Compare
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
e442725
to
983557a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: was it necessary to reorder the statements in parser.cc? I think the code is just moved around, but it makes the diff a bit harder to read
@scpeters, yes the reorder was on purpose. Values are now parsed dependent on the attribute |
thanks for clarifying; I hadn't reviewed the changes in #589, but I just looked and saw how it changed |
🦟 Bug fix
Fixes #696
Summary
Pose in include tags are parsed in a single
readXml
call, instead of recursively. Added parsing logic for attributedegrees
alongsiderelative_to
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge