Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/include pose degrees #697

Merged
merged 3 commits into from
Sep 10, 2021
Merged

Fix/include pose degrees #697

merged 3 commits into from
Sep 10, 2021

Conversation

aaronchongth
Copy link
Collaborator

@aaronchongth aaronchongth commented Sep 9, 2021

🦟 Bug fix

Fixes #696

Summary

Pose in include tags are parsed in a single readXml call, instead of recursively. Added parsing logic for attribute degrees alongside relative_to.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 9, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Sep 9, 2021
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: was it necessary to reorder the statements in parser.cc? I think the code is just moved around, but it makes the diff a bit harder to read

@scpeters scpeters moved this from Inbox to In review in Core development Sep 9, 2021
@aaronchongth
Copy link
Collaborator Author

@scpeters, yes the reorder was on purpose. Values are now parsed dependent on the attribute @degrees, if I kept the order, I would need to call Reparse() on the underlying value Param for the pose Element, after the attribute has been parsed.

@scpeters
Copy link
Member

@scpeters, yes the reorder was on purpose. Values are now parsed dependent on the attribute @degrees, if I kept the order, I would need to call Reparse() on the underlying value Param for the pose Element, after the attribute has been parsed.

thanks for clarifying; I hadn't reviewed the changes in #589, but I just looked and saw how it changed Param::SetFromString so this makes more sense now

@aaronchongth aaronchongth merged commit b9a37a0 into main Sep 10, 2021
@aaronchongth aaronchongth deleted the fix/include-pose-degrees branch September 10, 2021 07:13
Core development automation moved this from In review to Done Sep 10, 2021
@azeey azeey linked an issue Sep 10, 2021 that may be closed by this pull request
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Degrees don't work when used with include tags
2 participants