Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ToElement for ParticleEmitter and Link #781

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Added ToElement for ParticleEmitter and Link #781

merged 3 commits into from
Dec 10, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 9, 2021

Signed-off-by: Nate Koenig nate@openrobotics.org

🎉 New feature

Summary

Adds ToElement conversion function to ParticleEmitter and Link.

Test it

Run the tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Dec 9, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Dec 9, 2021
src/ParticleEmitter_TEST.cc Outdated Show resolved Hide resolved
iche033 and others added 2 commits December 9, 2021 13:56
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@nkoenig nkoenig requested a review from iche033 December 9, 2021 23:27
Core development automation moved this from Inbox to In review Dec 10, 2021
@nkoenig nkoenig merged commit 5b48e41 into sdf12 Dec 10, 2021
Core development automation moved this from In review to Done Dec 10, 2021
@nkoenig nkoenig deleted the link_toelement branch December 10, 2021 01:30
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants