Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD to SDF: Added Collisions #898

Merged
merged 123 commits into from
Apr 12, 2022
Merged

USD to SDF: Added Collisions #898

merged 123 commits into from
Apr 12, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 22, 2022

🎉 New feature

Summary

Added collisions to USD -> SDF converter

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

ahcorde and others added 30 commits March 9, 2022 13:22
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde and others added 5 commits April 8, 2022 16:11
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde marked this pull request as ready for review April 11, 2022 08:56
ahcorde and others added 4 commits April 11, 2022 13:25
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I left a few minor comments below. Would you mind adding tests?

usd/src/usd_parser/USDLinks.cc Outdated Show resolved Hide resolved
usd/src/usd_parser/USDLinks.cc Show resolved Hide resolved
Base automatically changed from ahcorde/usd_to_sdf_visuals to sdf12 April 11, 2022 21:21
@ahcorde ahcorde requested a review from adlarkin April 12, 2022 16:30
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde
Copy link
Collaborator Author

ahcorde commented Apr 12, 2022

@adlarkin Added tests 9ebffa3

Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Core development automation moved this from In progress to In review Apr 12, 2022
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #898 (f6038d8) into sdf12 (c1afd7f) will decrease coverage by 0.15%.
The diff coverage is 54.79%.

@@            Coverage Diff             @@
##            sdf12     #898      +/-   ##
==========================================
- Coverage   86.73%   86.57%   -0.16%     
==========================================
  Files         106      108       +2     
  Lines       15450    15528      +78     
==========================================
+ Hits        13401    13444      +43     
- Misses       2049     2084      +35     
Impacted Files Coverage Δ
usd/src/usd_parser/USDLinks.cc 46.41% <54.79%> (+0.62%) ⬆️
src/EmbeddedSdf.cc 100.00% <0.00%> (ø)
include/test_config.h 60.86% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1afd7f...f6038d8. Read the comment docs.

@ahcorde ahcorde enabled auto-merge (squash) April 12, 2022 21:44
@ahcorde ahcorde merged commit 276fcbf into sdf12 Apr 12, 2022
Core development automation moved this from In review to Done Apr 12, 2022
@ahcorde ahcorde deleted the ahcorde/usd_to_sdf_collisions branch April 12, 2022 22:11
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants