Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes MacOS Python tests #957

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Fixes MacOS Python tests #957

merged 3 commits into from
Apr 8, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 8, 2022

🦟 Bug fix

Summary

MacOS test for python interfaces is broken. I updated the PYTHONPATH trying to find the right path.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 8, 2022
@ahcorde ahcorde self-assigned this Apr 8, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 8, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Apr 8, 2022
@ahcorde ahcorde changed the title Fix macos build Fixes MacOS Python tests Apr 8, 2022
@ahcorde ahcorde moved this from Inbox to In review in Core development Apr 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #957 (318f3b6) into main (1d4cf25) will not change coverage.
The diff coverage is n/a.

❗ Current head 318f3b6 differs from pull request most recent head 8c90c0c. Consider uploading reports for the commit 8c90c0c to get more accurate results

@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         106      106           
  Lines       14826    14826           
=======================================
  Hits        13046    13046           
  Misses       1780     1780           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4cf25...8c90c0c. Read the comment docs.

Signed-off-by: ahcorde <ahcorde@gmail.com>
.github/workflows/macos.yml Outdated Show resolved Hide resolved
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@scpeters scpeters merged commit 66c1609 into main Apr 8, 2022
@scpeters scpeters deleted the ahcorde/python/fix_mac_build branch April 8, 2022 23:46
Core development automation moved this from In review to Done Apr 8, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants