-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kenya static site branch with configurations #12
base: kenya
Are you sure you want to change the base?
Conversation
Add configuration variables to jekyll static site
s3_website.yml
Outdated
@@ -1,6 +1,6 @@ | |||
s3_id: <%= ENV['AWS_ACCESS_KEY_ID'] %> | |||
s3_secret: <%= ENV['AWS_SECRET_ACCESS_KEY'] %> | |||
s3_bucket: opengazettes.or.ke | |||
s3_bucket: nigeria.opengazettes.co |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should be Kenya.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidLemayian Thanks. That's the config file I've been failing to change. I've moved the setting to use the environment variable set from the .env
file
@@ -8,7 +8,12 @@ | |||
# Site settings | |||
title: Open Gazettes Kenya | |||
email: gazettes@codeforafrica.org | |||
url: http://opengazettes.or.ke | |||
url: http://opengazettes.or.ng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should be Kenya.
Hey @andela-wcyn. ☝️ |
What does this PR do?
It adds the generic configuration settings to the
kenya
branch to reduce hard coding of valuesChanges Made
develop