Merge pull request #4 from howtwizer/musicans_destroy_promise_error_fix

[fix] Uncaught (in promise) on musicians destroy action
gbarillot · Jun 11, 2018 · ebe9cf1 · ebe9cf1
2 parents 329b0b7 + fccc581
commit ebe9cf1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/controllers/api/admin/musicians_controller.rb b/app/controllers/api/admin/musicians_controller.rb
@@ -36,7 +36,7 @@ def update
 
   def destroy
     if @musician.destroy
-      head 200
+      head 204
     else
       render json: {success: false, errors: @musician.errors.messages}.to_json, status: 422
     end

diff --git a/app/javascript/packs/admin/components/musicians/index.vue b/app/javascript/packs/admin/components/musicians/index.vue
@@ -62,7 +62,7 @@ export default {
     destroy: function(user_id) {
       if(confirm(this.$t('confirmation'))) {
         this.$store.dispatch('MusicianStore/destroy', user_id).then(
-          response => {
+            () => {
             this.$store.dispatch('MusicianStore/index');
           }
         )