Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a standard for slugs #81

Closed
dag7dev opened this issue Aug 14, 2021 · 3 comments
Closed

Define a standard for slugs #81

dag7dev opened this issue Aug 14, 2021 · 3 comments
Labels

Comments

@dag7dev
Copy link
Contributor

dag7dev commented Aug 14, 2021

As of now, I've decided for pouet importer to

  • convert everything to lowercase: duped entries will be "just" limited to different spelling
  • convert all special characters to unicode characters è --> e
  • all special characters are replaced with -
  • all spaces " " are replaced with -
  • no duplicate hyphen characters are repeated (for example midnight---cavalier would be midnight-cavalier)

I've found that many entries as of today are placed in the "main" folder with mixed case notation, so "Midnight-Cavalier" would be different from "Midnight-Cavalier", resulting in a duped entry.

So I propose to include the rules I've written above in guidelines for contributing, in this way we can limit duped entries!

@avivace
Copy link
Sponsor Member

avivace commented Aug 17, 2021

Makes sense! We can also suggest a "slugify" tool so this process becomes automatic, no?

@dag7dev
Copy link
Contributor Author

dag7dev commented Aug 17, 2021 via email

@avivace
Copy link
Sponsor Member

avivace commented Aug 17, 2021

I agrre, a common utils class works and such method could keep the old scrapers "functioning"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants