Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware register default value doesn't make sense on DMG for CGB-only registers #525

Open
SonoSooS opened this issue Dec 20, 2023 · 4 comments
Labels
content Improvements or additions to documentation

Comments

@SonoSooS
Copy link
Contributor

In the Power Up Sequence page, at the bottom is the hardware register table.

For example for the HDMA registers, it doesn't make sense that they read as $FF on DMG, as every register that doesn't exist reads as $FF, so it's slightly misleading. Technically correct, but nonsense.

It would be better if these registers would get flagged as -- or N/A or something similar, perhaps with a clarification at the end of the table that all undefined registers read as $FF.

If N/A in capital letters is chosen, it's difficult with vision problems to differentiate at a first glance from just a regular hexadecimal value in nearby cells, as it has the same height, and almost the same width, very much blending in with the other nearby cells.
Adding a footnote link (the superscripted tiny number to the right of the cell contents) should be a good step to make it slightly easier to differentiate if no non-intrusive differentation method is available.

@ISSOtm
Copy link
Member

ISSOtm commented Dec 20, 2023

Sure, -- should work too. (Perhaps three, so they stand out even if not in a <code> block.)

@calc84maniac
Copy link

I feel like I should bring this up since it's somewhat related, but the CGB-only registers in the CGB / AGB column are also misleading/technically correct, for DMG mode only (which isn't mentioned anywhere). Some registers are marked as ?? with a footnote for compatibility mode, but others are marked as $FF with no indication that it's not the actual value. I think it would be more useful to list the actual values of all these registers on CGB / AGB, and describe the $FF behavior in compatibility mode under the footnote for this issue.

@ISSOtm
Copy link
Member

ISSOtm commented Dec 20, 2023

I believe the GBC-only regs are still R/W in DMG mode, just inoperative? I'm not certain, though.

@calc84maniac
Copy link

No, they read as $FF and writes are ignored. I believe the current values were taken directly from the source code of a test ROM which runs in DMG mode, which was a bit of an oversight.

@avivace avivace added the content Improvements or additions to documentation label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants