Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework "Object Priority and Conflicts" section #331

Merged
merged 3 commits into from
Jul 25, 2021

Conversation

ISSOtm
Copy link
Member

@ISSOtm ISSOtm commented Jul 21, 2021

Fixes #12

Also added a link to a video (of mine, yes) and a NESDev thread showcasing examples of this happening with images.

@ISSOtm ISSOtm added content Improvements or additions to documentation consistency - style Content format, text style, consistency in presenting the informations labels Jul 21, 2021
@ISSOtm ISSOtm requested a review from avivace July 21, 2021 07:29
Copy link
Sponsor Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eldred. This looks like a very nice improvement overall. Re-clarifying the whole priority computing process is great.

My main issues here are over-stating and reinforcing concepts when really the manual-tone of the document should remain neutral. I've tried to fix all the occurences of this.

Also, for this kind of mechanism it may be worth to also aid the explanation with some simple flowcharts to introduce the general decision process implemented by the Game Boy, expanded by the details in the text (see #335).

src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
@ISSOtm
Copy link
Member Author

ISSOtm commented Jul 24, 2021

Applied and re-tweaked most suggested changes; they may be re-reviewed. A couple points are still to be discussed.

My main issues here are over-stating and reinforcing concepts when really the manual-tone of the document should remain neutral. I've tried to fix all the occurences of this.

Probably déformation professionnelle from gb-asm-tutorial, sorry about that :P

src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
src/OAM.md Outdated Show resolved Hide resolved
@ISSOtm
Copy link
Member Author

ISSOtm commented Jul 25, 2021

Alright, this should be OK now

@ISSOtm ISSOtm requested a review from avivace July 25, 2021 08:04
@avivace avivace merged commit 4a14dc1 into gbdev:master Jul 25, 2021
@ISSOtm ISSOtm deleted the prio-confl branch July 25, 2021 12:07
@avivace avivace moved this from In review to Done in Development Board Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency - style Content format, text style, consistency in presenting the informations content Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

Sprite Priorities and Conflicts is badly written / not fitting the documentation formal style
2 participants