-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply misc. graphics-related fixups #341
Conversation
Bump |
I'm on this |
src/Scrolling.md
Outdated
WX values 0 and 166 are unreliable due to hardware bugs. | ||
|
||
If WX is set to 0, the window will "stutter" horizontally when SCX changes | ||
(depending on SCX modulo 8, behavior is a little complicated so you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(depending on SCX modulo 8, behavior is a little complicated so you | |
(depending on SCX modulo 8, detailed behaviour is unknown) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(depending on SCX modulo 8, behavior is a little complicated so you | |
(depending on SCX modulo 8, exact behavior is a little complicated). |
It is properly understood, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then why is the reader invited to "try it himself because it's too complicated to explain"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think because I couldn't find it documented anywhere (guess I could have taken a look at SameBoy's source?), and I thought that it wouldn't be worth explaining in full there. I was probably wrong with that, but then what shall we do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can link SameBoy source if that's implemented there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fond of that because AFAIK there is no test ROM for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't have a source, we can't provide details then we shouldn't mention it at all. Just open an Issue and mark it as research. Makes no sense to add confusion here mentioning stuff in half.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then just
(depending on SCX modulo 8, behavior is a little complicated so you | |
(depending on SCX modulo 8). |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(But still an Issue is worth opening)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @ISSOtm
Co-authored-by: Antonio Vivace <dev@avivace.com>
Up for debate, of course.