Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING document #372

Merged
merged 11 commits into from
Oct 11, 2021
Merged

Add CONTRIBUTING document #372

merged 11 commits into from
Oct 11, 2021

Conversation

avivace
Copy link
Sponsor Member

@avivace avivace commented Oct 2, 2021

See #370. Mostly I ported over the stuff that it's currently in the wiki.

@avivace avivace requested a review from ISSOtm October 2, 2021 15:50
@avivace avivace added the meta label Oct 2, 2021
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! A very welcome change, despite my usual lot of nitpicks :P

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated

### 1. Conventions documentation

A short paragraph introducing and clarifying the conventions used in the document must be placed (and kept updated) in the top of the document.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link to an example?

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we ever agreed on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this clause, or on the example?

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think we should remove this point till we decide about this "introductory" paragraph

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, yeah. It seems to overlap a lot with #194, anyway.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved

### 7. Mentioning models

We use the console codenames, so:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for designating a single model, but we often need shorthands to designate all color-supporting models. Do we have a convention for those?

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have one yet

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
avivace and others added 7 commits October 3, 2021 16:36
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ISSOtm
Copy link
Member

ISSOtm commented Oct 10, 2021

Alright! Now we just need to:

  • Remove 1.
  • Figure out what to do with the rest of the codenames
  • Figure out the model grouping.

Awesome!

@avivace
Copy link
Sponsor Member Author

avivace commented Oct 10, 2021

Alright! Now we just need to remove 1., figure out what to do with the rest of the codenames, and the model grouping. Awesome!

Done, I think it's a nice starting point.

@ISSOtm
Copy link
Member

ISSOtm commented Oct 10, 2021

Yep. Let's discuss the more uncommon codenames, then?

@avivace
Copy link
Sponsor Member Author

avivace commented Oct 11, 2021

Yep. Let's discuss the more uncommon codenames, then?

I think that can be done in a second moment? The purpose of this PR was to bring what we had in the wiki in a more formalilzed way

@ISSOtm
Copy link
Member

ISSOtm commented Oct 11, 2021

Okay. Just needs rebasing and it'll be ready to merge, then.

@avivace
Copy link
Sponsor Member Author

avivace commented Oct 11, 2021

Okay. Just needs rebasing and it'll be ready to merge, then.

On it!

@avivace avivace merged commit e4e42eb into master Oct 11, 2021
@avivace avivace mentioned this pull request Oct 12, 2021
@avivace avivace deleted the add-contributing branch June 13, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants