-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintainership of the project #369
Comments
I can certainly empathise with your situation, but first: I'd like to thank you for doing a great job maintaining rgbds! Going forward, I think either of these are sensible options. As for what I can do to help you out: Regarding Option 2: I'm personally in a similar situation to you, so I haven't contributed much lately, and would be reluctant to take over maintenance of rgbds (at the moment, at least). Regarding Option 1: However, I have still been keeping an eye on the project, so, @AntonioND, if you ever would like a another pair of eyes to look at a PR (such as the one you linked), feel free to request a review from me, and I'll take a look as soon as I can. (Though I can't guarantee that I'll take a look at all of them without being prompted) Of course, the more reviewers, the better – so it'd be great if we could get code reviews, approvals, and change requests from other people with an interest in these PRs! (w.r.t. write access: if you're referring to the three members of the rednex organisation, I don't seem to have write access to this repo, but I do have access to Travis… Apologies if you're referring to someone else!) (also, thanks for linking to that issue; that certainly was a scary situation! 😰) |
You're not getting paid for this. It's perfectly understandable that you have other priorities. I can try to help review some PRs. |
I would like to apply for push access to this repository. While I don't know the code base nearly as much as any of you three, I believe I know enough that I can learn as I go, especially from other members' reviews; however, I am very active and willing to tackle issues and review PRs, especially as a regular and power user of RGBDS. I know asking this is pretty blunt of me, but you seem to be really lacking time and/or motivation lately (and it's fine, honestly), and nobody else seems willing to take the position. As for what damage I could do to the code base (referring to that event-stream problem), I think I've been in GBDev for long enough, and that my real identity is clear enough, that there is no risk. |
@ISSOtm fine by me, I've added you. |
Thank you! |
Hi all,
It's no secret that I haven't been as responsive as a maintainer should be. Maintaining this project hasn't been a priority for me for some time and I don't want to be responsible for merging changes such as #329 without proper review. I just have other things going on in my life.
Basically, there are two options:
External contributors decide to review code and make it easier for me to trust PRs so that I can merge them quickly (please, use the code review features of GitHub so that it's clear that you agree with the PR). If this is the case I'm happy to keep merging PRs and dealing with the admin stuff of this project.
Someone else decides to take maintainership of the project and deal with all possible issues that arise in the future. I would step down as maintainer in that case.
I should also mention that I'm not the only one with write access to this repository. In case something happened to me there are other 2 people that could take care of this (I think).
I will try to take a look at all PRs in the following days (sorry about the huge delays).
I should also mention I'm concerned about the possibility of something like this happening (as unlikely as it may be with this niche project): dominictarr/event-stream#116
The text was updated successfully, but these errors were encountered: