Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake build of RGBDS links wrong libpng on macOS #573

Closed
ISSOtm opened this issue Sep 20, 2020 · 0 comments · Fixed by #578
Closed

CMake build of RGBDS links wrong libpng on macOS #573

ISSOtm opened this issue Sep 20, 2020 · 0 comments · Fixed by #578
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! good first issue New to the codebase? You can help no problem!

Comments

@ISSOtm
Copy link
Member

ISSOtm commented Sep 20, 2020

As evidenced here, the wrong libpng version is loaded.
According to a StackOverflow question, this is because CMake detects the system version (1.4, seriously, Apple?) and links against it, but the Homebrew version is ran with. The StackOverflow question has no answers, besides the asker posting about a hack.
@ISSOtm ISSOtm added the bug Unexpected behavior / crashes; to be fixed ASAP! label Sep 20, 2020
@AntonioND AntonioND mentioned this issue Sep 20, 2020
Closed
@avivace avivace added the good first issue New to the codebase? You can help no problem! label Sep 20, 2020
@JL2210 JL2210 mentioned this issue Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! good first issue New to the codebase? You can help no problem!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pkg-config to detect libpng JL2210/rgbds
2 participants
@avivace @ISSOtm