Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginner friendly issues #569

Closed
avivace opened this issue Sep 18, 2020 · 16 comments
Closed

Beginner friendly issues #569

avivace opened this issue Sep 18, 2020 · 16 comments
Assignees
Labels
meta This isn't related to the tools directly: repo organization, maintainership...

Comments

@avivace
Copy link
Sponsor Member

avivace commented Sep 18, 2020

Hi! If you want to begin contributing to RGBDS—first of all, thank you!—we try to tag issues that are easier for beginners to tackle: search for the "good first issue" tag!

Original post below.


Hi, fellow RGBDS contributors and enthusiasts,

I'd like the @gbdev/rednex team to help me in flagging some beginner friendly issues: tasks that can help join the project and let people familiarise with our tools while contributing. I've created a "beginner-friendly" label you can use.

If you open new issues or split the existing ones in more "attackable" and easy issues it's good, too!

I'm looking for easy to understand tasks that can be carried out without having too much context (e.g. QoL, fixes, documentaiton, ...).

I'm asking you this for the following reasons:

  • Hacktoberfest is coming, and every year it attracts a lot of quality contributions and traffic. This could be useful to get more people involved and interested in our projects.
  • I'm planning to investing some of the donations we are getting as gbdev community to promote the development of our projects. Having some good issues to put rewards on would be fantastic!
  • We now have a RGBDS website and expanding out outreach is definitely something we should look forward to.
@avivace avivace added the meta This isn't related to the tools directly: repo organization, maintainership... label Sep 18, 2020
@ISSOtm
Copy link
Member

ISSOtm commented Sep 18, 2020

Ouch, this is actually something I feared. I think that the main problem with almost every issue is the lack of docs on how the code is structured. Based on that, I'm reluctant to mark any issue as "beginner-friendly", as all that require touching the code have that implicit barrier of entry of actually understanding the code.
We should write the docs ourselves, but that'll take some time, and mine is going to get a severe cut starting next week.

Non-"code" issues are essentially auxiliary stuff like #469, so that wouldn't contribute where it matters.

Dunno, really. I'm torn.

@AntonioND
Copy link
Member

AntonioND commented Sep 19, 2020

Yeah, the only things I can think of are things like testing, or making the documentation prettier. It was pretty tricky to start doing things in this codebase but, at least, there were quite a few small tasks to do back then.

As long as #485 is open, most small things are blocked.

@JL2210
Copy link
Member

JL2210 commented Sep 19, 2020

List of somewhat beginner-friendly issues:

@AntonioND
Copy link
Member

#151 for sure, and I think it would be useful to have regression tests...

@ISSOtm
Copy link
Member

ISSOtm commented Sep 20, 2020

Maybe it'd be worth merging #557 in its current state, then? I don't think it's too bad in its current state anyways, mostly fairly minor issues. Proper string management would be good, though...

@AntonioND
Copy link
Member

Well, I don't think it's a crazy idea, for sure. Maybe we could tag a new version right now, merge that PR afterwards, and fix issues as they come up before the next tag.

@AntonioND
Copy link
Member

I will take a look at the PR tonight.

@AntonioND
Copy link
Member

AntonioND commented Sep 20, 2020

This one should be easy, though: #573

And useful for mac users.

@ISSOtm
Copy link
Member

ISSOtm commented Sep 22, 2020

Note: it's also imperative to run the tests and code style checks on PRs. Currently, checkpatch is broken...

@JL2210
Copy link
Member

JL2210 commented Sep 22, 2020

We should make an issue for that and see if a beginner can fix it

@ISSOtm
Copy link
Member

ISSOtm commented Sep 22, 2020

Given the trouble I'm having with it, probably not. Besides, it'd block everything else, so not worth it.

@ISSOtm
Copy link
Member

ISSOtm commented Sep 22, 2020

As far as my testing goes, 6528a95 made checkpatch work again. We'll see on the next PR opened, I guess.

@ISSOtm ISSOtm pinned this issue Sep 22, 2020
@ISSOtm ISSOtm unpinned this issue Dec 12, 2020
@ISSOtm ISSOtm pinned this issue Dec 12, 2020
@ISSOtm
Copy link
Member

ISSOtm commented Dec 12, 2020

The issue itself has been resolved, so closing. I'll be keeping it pinned in the issues tab, so it will stay accessible nonetheless.

@ISSOtm ISSOtm closed this as completed Dec 12, 2020
@avivace
Copy link
Sponsor Member Author

avivace commented Dec 12, 2020

The issue itself has been resolved, so closing. I'll be keeping it pinned in the issues tab, so it will stay accessible nonetheless.

If beginner issues keep being tracked with a label, it's not even necessary to keep this pinned.

@ISSOtm
Copy link
Member

ISSOtm commented Dec 12, 2020

A beginner coming to this page may not think that such a label exists, so I edited this issue's top post to link to the search criterion for it.

@avivace
Copy link
Sponsor Member Author

avivace commented Dec 12, 2020

A beginner coming to this page may not think that such a label exists, so I edited this issue's top post to link to the search criterion for it.

Great, okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta This isn't related to the tools directly: repo organization, maintainership...
Projects
None yet
Development

No branches or pull requests

4 participants