-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support -P/--preinclude
to pre-INCLUDE a file
#1043
Conversation
I would use |
1d48ef4
to
48dd13b
Compare
The main problem I have with this, is users trying to get into a codebase, not figuring out where all of these symbols are defined. Again, what's wrong with |
Constants which should be in every single file should be there by default without the programmer having to remember them. Users not knowing where constants are defined is already a problem with -D or a master file in a unity build or exported constants (something you recommend). This just makes the experience a little less repetitive for the file or two which is needed everywhere. If it’s something someone doesn’t like because it might be confusing, they can simply not use the feature; the same applies to GCC’s -i. |
There are pretty many possible sources of implicit behavior beyond what's in an .asm file that users have to learn about: |
8b7694e
to
dd26761
Compare
-I/--includefile
to pre-INCLUDE a file-f/--includefile
to pre-INCLUDE a file
7838aed
to
db5688e
Compare
Following discussion with @ISSOtm , call this |
db5688e
to
fadd225
Compare
-f/--includefile
to pre-INCLUDE a file-P/--preinclude
to pre-INCLUDE a file
fadd225
to
9e5b494
Compare
Made some changes to the docs locally to ensure they render correctly. |
Fixes #1041