allow defining local labels for another scope #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
reviewed
Aug 17, 2023
Rangi42
reviewed
Aug 17, 2023
Rangi42
added
enhancement
ISSOtm
previously requested changes
Aug 17, 2023
Rangi42
reviewed
Aug 18, 2023
Rangi42
reviewed
Aug 18, 2023
|
Looks good! Thanks for bearing with my comments. Just needs CI to pass. |
|
Thank you. Every job except checkpatch is passing. Does checkpatch compare only the states of the tree before and after the combined effect of the patches, or does it compare each patch? If the latter, how would I go about rewriting history to get the job to pass? |
In your local repo, rebase this branch to |
fix gbdev#1157 for the following source code ``` section "hSAVE_locals",HRAM func3.hSpam: ds 1 ; no longer produces an error ;.hEggs: ds 1 ; uncomment this to see the new error section "demo",ROM0 func3: ldh a, [.hSpam] ret ``` Remove two errors: - `Not currently in the scope of 'func3'` - `Local label 'func3.hSpam' in main scope` Add one error: - `Relative local label '.hSpam' in main scope` Add a switch to restore previous behavior in `include/asm/symbol.h` ```c ``` update tests of local label definition failure now that local label definition is more lenient, fewer tests should fail begin removing issue number from test Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> treat ALLOW_LOCAL_LABEL_ANYWHERE as always on - don't gate the new lenient behavior behind a build-time condition - change "Relative local label" to "Unqualified local label" in an error message realign tests of local labels with wrong parent - repurpose test/asm/sym-scope from a test of producing correct errors to a successful test - remove test/asm/local-wrong-parent because it is now a redundant successful test based on suggestions by @Rangi42
pinobatch
force-pushed
the
rm-parent-scope-requirement
branch
from
d78fc21
to
4e9c4fa
Compare
Rangi42 suggested through Discord to bundle the zlib13 update (gbdev#1163) with this
Rangi42
approved these changes
Aug 19, 2023
ISSOtm
approved these changes
Aug 20, 2023
pinobatch
added a commit
to pinobatch/libbet
that referenced
this pull request
Aug 25, 2023
- add missing "Closet" map name - stpcpy as an example of forward-declaring a member of a local scope - explain that forthcoming RGBDS 0.6.2 (or a master build allowing forward-declaring a member of a local scope) is required <gbdev/rgbds#1159> - explain how to get a master build on Windows until 0.6.2 is ready <gbdev/rgbds-www#49> - update URL of RGBDS - Catskull is out of business <https://catskullelectronics.com/pages/the-end-of-catskull-electronics>
pinobatch
added a commit
to pinobatch/240p-test-mini
that referenced
this pull request
Aug 25, 2023
- stpcpy and apustpcpy as examples of forward-declaring a member of a local scope - explain that forthcoming RGBDS 0.6.2 (or a master build allowing forward-declaring a member of a local scope) is required <gbdev/rgbds#1159> - explain how to get a master build on Windows until 0.6.2 is ready <gbdev/rgbds-www#49> - update URL of RGBDS - Catskull is out of business <https://catskullelectronics.com/pages/the-end-of-catskull-electronics>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1157 for the following source code
Remove two errors:
Not currently in the scope of 'func3'Local label 'func3.hSpam' in main scopeAdd one error:
Relative local label '.hSpam' in main scopeAdd a switch to restore previous behavior in
include/asm/symbol.h