Linker scripts can align to offsets, and require valid alignments #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
added
enhancement
ISSOtm
previously requested changes
Dec 16, 2023
There was a problem hiding this comment.
The logic seems sound, the test case is alright, except for one semantics request and *censored* UB; the documentation is Not Great, but I re-read the entire man page and I think it needs to be overhauled entirely, which I'll thus defer to a later PR for the purpose of scoping.
Rangi42
dismissed
ISSOtm’s stale review
Resolved, alignment 16 is valid and not UB
ISSOtm
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1268
Fixes #1270