Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for gbif/ipt#1248 #1284

Merged
merged 2 commits into from
Sep 30, 2016
Merged

fix for gbif/ipt#1248 #1284

merged 2 commits into from
Sep 30, 2016

Conversation

pieterprovoost
Copy link
Contributor

Quick fix for #1248, please check.

@kbraak
Copy link
Contributor

kbraak commented Sep 29, 2016

Thank you for this pull request @pieterprovoost

In case you weren't aware, there is a set of unit tests related to DCAT generation: https://github.com/gbif/ipt/blob/master/src/test/java/org/gbif/ipt/task/GenerateDCATTest.java

I would have expected an update here to ensure that non published datasets don't get included in the feed - can you please take a look? Thanks for your help.

@pieterprovoost
Copy link
Contributor Author

This doesn't impact DCAT, just RSS. I'll try to add a unit test in https://github.com/gbif/ipt/blob/master/src/test/java/org/gbif/ipt/service/manage/impl/ResourceManagerImplTest.java

@kbraak
Copy link
Contributor

kbraak commented Sep 30, 2016

Sorry @pieterprovoost you're right, my mistake. Adding a test for the 'latest' method would be a valuable addition if you could make that, thanks again for your help.

@pieterprovoost
Copy link
Contributor Author

I have made a few more changes and added a test for latest(). RSS feed generation now only checks the last published version of a dataset.

@kbraak kbraak merged commit 4c9016f into gbif:master Sep 30, 2016
@kbraak
Copy link
Contributor

kbraak commented Sep 30, 2016

Thank you very much @pieterprovoost, that was perfect. Are there any other pressing issues that you need fixed?

@pieterprovoost
Copy link
Contributor Author

@kbraak No, just that one, thanks.

@kbraak
Copy link
Contributor

kbraak commented Jan 10, 2017

@pieterprovoost

I really appreciated receiving your help on this issue. I wanted to say thanks again by acknowledging your contribution in the following blog post that promotes the latest IPT 2.3.3 release: http://gbif.blogspot.dk/2017/01/ipt-v233-your-repository-for.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants