Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRSciColl - Lookup - if ID matches and code is alternative code, make exact match #381

Closed
ManonGros opened this issue Sep 9, 2021 · 3 comments
Assignees
Labels
GRSciColl Issues related to institutions, collections and staff

Comments

@ManonGros
Copy link
Contributor

This is an example where the InstitutionID matches the GRSciColl institution and the code matches one of its alternative codes but the match is still fuzzy: https://www.gbif.org/occurrence/3311063329

I think in these cases, we should have an exact match.

@ManonGros ManonGros added the GRSciColl Issues related to institutions, collections and staff label Sep 9, 2021
@rukayaj
Copy link

rukayaj commented Oct 11, 2021

It looks like this has been fixed in @ManonGros's example? But we're still experiencing it here https://www.gbif.org/occurrence/2985156700

@marcos-lg
Copy link
Contributor

In that example it's using the actual code (not the alternative code anymore) so that's why it looks fixed.

Anyway I've been working on this fix recently but it's still not deployed in production. I expect to deploy it this week or next week the latest. I'll comment on this issue when it's done.

@marcos-lg
Copy link
Contributor

This is deployed to PROD but the results are cached and we refresh them once a week and the next refresh will be next Thursday so we will have to wait a little to see the changes in the portal. Also, when the cache is refreshed the datasets have to be reinterpreted.

If there are cases where this is urgent to fix we can speed it up. Just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GRSciColl Issues related to institutions, collections and staff
Projects
None yet
Development

No branches or pull requests

3 participants