Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More API streamlining for v2 #1148

Merged
merged 13 commits into from
Mar 15, 2024
Merged

More API streamlining for v2 #1148

merged 13 commits into from
Mar 15, 2024

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Mar 13, 2024

Resolves #1142. Deprecations for v1 to prep for these changes are in #1146. This PR:

  • moves the utils_graph module's get_digraph, get_undirected, graph_to_gdfs, and graph_from_gdfs functions to a new convert module that houses data type converters
  • moves the utils_graph module's remove_isolated_nodes and get_largest_component functions to the truncate module
  • moves the utils_graph module's route_to_gdf function to the routing module
  • move the speed module's functionality to the routing module
  • deletes the now-empty utils_graph and speed modules
  • renames the functions get_largest_component -> largest_component, get_undirected -> to_undirected, and get_digraph -> to_digraph

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.98%. Comparing base (b77689b) to head (550598d).

Files Patch % Lines
osmnx/routing.py 91.04% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1148      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files          25       24       -1     
  Lines        2440     2432       -8     
==========================================
- Hits         2391     2383       -8     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing merged commit bb64517 into v2 Mar 15, 2024
6 of 7 checks passed
@gboeing gboeing deleted the api branch March 15, 2024 15:17
@gboeing gboeing mentioned this pull request Mar 15, 2024
13 tasks
@gboeing
Copy link
Owner Author

gboeing commented May 3, 2024

The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant