Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0 development #1106

Merged
merged 418 commits into from
May 1, 2024
Merged

Version 2.0.0 development #1106

merged 418 commits into from
May 1, 2024

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Jan 11, 2024

Overview

This PR consolidates development work for OSMnx v2.0.0, targeted for release later in 2024.

Migrating to v2

See the migration guide at #1123.

Changes

See changelog for complete details.

This PR incorporates several other PRs prior to merging into the main branch:

Also includes work done in #1139, #1144, #1145, #1147, #1149, #1153, #1155, #1160.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: Patch coverage is 98.61472% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 98.31%. Comparing base (cbe05f1) to head (eeb98bf).
Report is 47 commits behind head on main.

❗ Current head eeb98bf differs from pull request most recent head a003557. Consider uploading reports for the commit a003557 to get more accurate results

Files Patch % Lines
osmnx/simplification.py 95.18% 4 Missing ⚠️
osmnx/plot.py 96.90% 3 Missing ⚠️
osmnx/convert.py 96.00% 2 Missing ⚠️
osmnx/stats.py 93.93% 2 Missing ⚠️
osmnx/utils.py 88.23% 2 Missing ⚠️
osmnx/distance.py 98.36% 1 Missing ⚠️
osmnx/routing.py 97.61% 1 Missing ⚠️
osmnx/truncate.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
+ Coverage   97.72%   98.31%   +0.58%     
==========================================
  Files          28       24       -4     
  Lines        2547     2368     -179     
==========================================
- Hits         2489     2328     -161     
+ Misses         58       40      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EwoutH and others added 11 commits April 25, 2024 09:50
This commit updates the consolidate_intersections function to accept the tolerance parameter as either a float or a dictionary mapping node IDs to floats.

It removes the previously suggested tolerance_attribute.
Update `_merge_nodes_geometric` to manage absent tolerance values by reverting to original geometries instead of creating POLYGON EMPTY.
Don't cover the actual behaviour, just check if passing a dictionary (with and without all nodes covered) leads to a runtime error or not.
Add node-specific tolerances to intersection consolidation
@gboeing gboeing changed the title [WIP] version 2.0.0 development Version 2.0.0 development Apr 25, 2024
@gboeing gboeing merged commit 43ab2e0 into main May 1, 2024
7 checks passed
@gboeing gboeing deleted the v2 branch May 1, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants