Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling slot management pausing #704

Merged
merged 9 commits into from
May 19, 2021
Merged

allow disabling slot management pausing #704

merged 9 commits into from
May 19, 2021

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented May 9, 2021

fixes #697

This PR allows the user to configure whether OSMnx should check the overpass server status endpoint for how long to pause before making the next request. That check is necessary if the server uses slot management, but the setting can (should) be disabled if you are running your own overpass instance.

@codecov
Copy link

codecov bot commented May 9, 2021

Codecov Report

Merging #704 (c362ec0) into main (4a93e6f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   97.10%   97.14%   +0.04%     
==========================================
  Files          24       24              
  Lines        2415     2417       +2     
==========================================
+ Hits         2345     2348       +3     
+ Misses         70       69       -1     
Impacted Files Coverage Δ
osmnx/downloader.py 97.14% <ø> (+0.47%) ⬆️
osmnx/settings.py 100.00% <100.00%> (ø)
osmnx/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a93e6f...c362ec0. Read the comment docs.

@gboeing
Copy link
Owner Author

gboeing commented May 9, 2021

@jannefleischer would you like to test this proposed fix to your issue #697? I appreciate it!

@gboeing gboeing merged commit c17ad72 into main May 19, 2021
@gboeing gboeing deleted the rate_limit branch May 19, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant