Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tolerant linking to Cocoda via URL with mapping #299

Closed
nichtich opened this issue Mar 14, 2019 · 1 comment
Closed

More tolerant linking to Cocoda via URL with mapping #299

nichtich opened this issue Mar 14, 2019 · 1 comment
Labels
low priority maybe later
Milestone

Comments

@nichtich
Copy link
Member

Linking into the application with a mapping requires the parameters:

  • fromScheme
  • toScheme
  • from
  • to
  • mapping

The last parameter should be enough (example link). If no concept scheme and/or no concept is selected left or right, the missing query values of fromScheme, toScheme, from, to can be guessed from the mapping.

@nichtich nichtich added the low priority maybe later label Mar 14, 2019
@nichtich nichtich added this to the 0.8.2 milestone Mar 14, 2019
@stefandesu
Copy link
Member

I implemented it this way:

  • For each side (from/to):
    • If no scheme was set, set scheme from mapping.
    • If scheme from mapping was set, also set concept from mapping.

In case a scheme was already set in fromScheme or toScheme, the concept will currently not be set from the mapping. We can add this later by comparing the scheme in fromScheme/toScheme from the mapping scheme and setting it only when they match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority maybe later
Projects
None yet
Development

No branches or pull requests

2 participants