feat: Either mapError #1882
Closed
feat: Either mapError #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkamperis
reviewed
May 26, 2023
| @@ -98,7 +98,7 @@ Added in v2.0.0 | |||
| - [getApplicativeValidation](#getapplicativevalidation) | |||
| - [getOrElse](#getorelse) | |||
| - [getOrElseW](#getorelsew) | |||
| - [mapLeft](#mapleft) | |||
| - [mapError](#maperror) | |||
There was a problem hiding this comment.
conceptually Either contains 2 values. Don't think there is a certainty for Left to be an "error".
There was a problem hiding this comment.
EDIT: Yeah, mapError in Either.ts was intentionally omitted (no mapError in @effect/data/Either as well)
There was a problem hiding this comment.
Okay, kinda makes sense. The inconsistency is unfortunate tho as now the TaskEither or ReaderTaskEither have the mapError while the Either doesn't.
True, the Either doesn't need to represent success / fail and can be used for anything where distinction for two outcomes is desired. But, at least from my experience, it is used for failable computations most of the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1851