Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapFromEntries codec added #172

Merged
merged 2 commits into from
Oct 12, 2022
Merged

mapFromEntries codec added #172

merged 2 commits into from
Oct 12, 2022

Conversation

mlegenhausen
Copy link
Contributor

This is an adaption of the setFromArray codec but for Map which converts a Map to an array of key-value tuples.

@gcanti
Copy link
Owner

gcanti commented Oct 11, 2022

@mlegenhausen about the naming convention, what do you think about *FromEntries instead of *FromPairs?

@mlegenhausen
Copy link
Contributor Author

Sure thing

@mlegenhausen mlegenhausen changed the title mapFromPairs codec added mapFromEntries codec added Oct 12, 2022
@mlegenhausen
Copy link
Contributor Author

Done

@gcanti gcanti merged commit d132c73 into gcanti:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcanti gcanti gcanti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlegenhausen @gcanti