Skip to content
This repository has been archived by the owner on Mar 20, 2019. It is now read-only.

fix WebSocket handshake without SafeBrowsing #113

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

xsmile
Copy link
Collaborator

@xsmile xsmile commented Oct 27, 2017

With 570141 WebSocket handshakes are broken if safebrowsing is disabled, see #112.

This change fixes the issue.

@gcarq
Copy link
Owner

gcarq commented Oct 27, 2017

Good catch

@gcarq gcarq merged commit f309c16 into develop Oct 27, 2017
@Eloston
Copy link
Contributor

Eloston commented Oct 27, 2017

Nice find, and nice work! It just seemed too strange and unnecessary for SafeBrowsing to touch WebSockets, but I guess SafeBrowsing wouldn't be considered safe without checking everything that goes through the browser.

Out of curiosity, how did you find this change? Did you just search through the list of changes, or did something in the code hint towards it?

@gcarq gcarq deleted the hotfix/safebrowsing-websockets branch October 27, 2017 20:05
@xsmile
Copy link
Collaborator Author

xsmile commented Oct 27, 2017

@Eloston, Going through the changes in the safebrowsing patch one more time, I couldn't find anything useful and then had the assumption that Chromium might still use some parts of SafeBrowsing when handling WebSockets. Since the safe_browsing_service is no more, this obviously leads to problems.

I found the commit rather by accident while looking up the kNetworkService option.

xsmile pushed a commit that referenced this pull request Jan 31, 2018
fix WebSocket handshake without SafeBrowsing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants