gh-3059 Nullpointers and Test cache clearing

gchq · Nov 3, 2023 · 11f406e · 11f406e
1 parent a3f2597
commit 11f406e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/...ore/src/main/java/uk/gov/gchq/gaffer/federatedstore/util/ApplyViewToElementsFunction.java b/...ore/src/main/java/uk/gov/gchq/gaffer/federatedstore/util/ApplyViewToElementsFunction.java
@@ -183,8 +183,9 @@ private static ViewElementDefinition getUpdatedViewElementDef(final SchemaElemen
         if (view != null) {
             final ViewElementDefinition viewElementDef = view.getElement(elementKey);
             //Add View Validation
-            updatedFilterFunctions.addAll(viewElementDef.getPostAggregationFilter().getComponents());
-
+            if (viewElementDef != null && viewElementDef.hasPostAggregationFilters()) {
+                updatedFilterFunctions.addAll(viewElementDef.getPostAggregationFilter().getComponents());
+            }
             //Init Builder with contents of the view.
             updatePreAggregationFiler = new ViewElementDefinition.Builder(viewElementDef);
         } else {

diff --git a/...re/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreViewAggregationTest.java b/...re/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreViewAggregationTest.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2022 Crown Copyright
+ * Copyright 2022-2023 Crown Copyright
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -42,6 +42,7 @@
 import static uk.gov.gchq.gaffer.federatedstore.FederatedStoreTestUtil.addGraphToAccumuloStore;
 import static uk.gov.gchq.gaffer.federatedstore.FederatedStoreTestUtil.contextTestUser;
 import static uk.gov.gchq.gaffer.federatedstore.FederatedStoreTestUtil.loadSchemaFromJson;
+import static uk.gov.gchq.gaffer.federatedstore.FederatedStoreTestUtil.resetForFederatedTests;
 
 public class FederatedStoreViewAggregationTest {
 
@@ -50,6 +51,8 @@ public class FederatedStoreViewAggregationTest {
 
     @BeforeEach
     public void before() throws Exception {
+        resetForFederatedTests();
+
         federatedStore = new FederatedStore();
         federatedStore.initialise(GRAPH_ID_TEST_FEDERATED_STORE, new Schema(), new FederatedStoreProperties());
 

diff --git a/...gchq/gaffer/federatedstore/operation/handler/impl/FederatedOperationChainHandlerTest.java b/...gchq/gaffer/federatedstore/operation/handler/impl/FederatedOperationChainHandlerTest.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2022 Crown Copyright
+ * Copyright 2016-2023 Crown Copyright
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -55,6 +55,7 @@
 import static uk.gov.gchq.gaffer.federatedstore.FederatedStoreTestUtil.GRAPH_ID_ACCUMULO_WITH_EDGES;
 import static uk.gov.gchq.gaffer.federatedstore.FederatedStoreTestUtil.GRAPH_ID_ACCUMULO_WITH_ENTITIES;
 import static uk.gov.gchq.gaffer.federatedstore.FederatedStoreTestUtil.GRAPH_ID_TEST_FEDERATED_STORE;
+import static uk.gov.gchq.gaffer.federatedstore.FederatedStoreTestUtil.resetForFederatedTests;
 import static uk.gov.gchq.gaffer.federatedstore.util.FederatedStoreUtil.getDefaultMergeFunction;
 import static uk.gov.gchq.gaffer.federatedstore.util.FederatedStoreUtil.getFederatedOperation;
 
@@ -91,8 +92,7 @@ public class FederatedOperationChainHandlerTest {
     @BeforeEach
     @AfterEach
     public void after() {
-        HashMapGraphLibrary.clear();
-        CacheServiceLoader.shutdown();
+        resetForFederatedTests();
     }
 
     @SuppressWarnings({"unchecked", "rawtypes"})