Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a /properties endpoint to the REST API #1420

Closed
p013570 opened this issue Oct 13, 2017 · 1 comment
Closed

Add a /properties endpoint to the REST API #1420

p013570 opened this issue Oct 13, 2017 · 1 comment
Assignees
Labels
enhancement Improvement to existing functionality/feature
Milestone

Comments

@p013570
Copy link
Member

p013570 commented Oct 13, 2017

This should allow a predefined set of properties/configuration to be exposed.

GET /properties should return a map of all exposed property key values.
GET /properties/{name} should return the value of the property with the given name.

The set of exposed properties should be configured in rest.properties. E.g

gaffer.properties=gaffer.properties.app-description,some-other-property
gaffer.properties.app-description="This is a description about the this application"
gaffer.properties.some-other-property="This is some other property"
gaffer.properties.some-hidden-property="This is some other hidden property"

So /properties would return:

{
"gaffer.properties.app-description": "This is a description about the this application",
"gaffer.properties.some-other-property": "This is some other property",
}

/properties/gaffer.properties.app-description would return:

"This is a description about the this application"

/properties/gaffer.properties.some-hidden-property would throw some error saying something like "gaffer.properties.some-hidden-property" is not a recognised property.

The system-description property could then be used in issue #1419.

@p013570 p013570 added enhancement Improvement to existing functionality/feature p:normal labels Oct 13, 2017
@p013570 p013570 added this to the v1.2.0 milestone Oct 13, 2017
@james010101101 james010101101 self-assigned this Oct 17, 2017
james010101101 added a commit that referenced this issue Oct 27, 2017
p013570 added a commit that referenced this issue Oct 31, 2017
p013570 added a commit that referenced this issue Oct 31, 2017
…-to-the-REST-API

Added a /properties endpoint, with the ability to configure which pro…
@p013570 p013570 modified the milestones: v1.2.0, v1.1.0 Oct 31, 2017
@p013570
Copy link
Member Author

p013570 commented Oct 31, 2017

Merged into develop.

@p013570 p013570 closed this as completed Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Development

No branches or pull requests

2 participants