Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example jar has invalid main class #201

Closed
p013570 opened this issue May 12, 2016 · 2 comments
Closed

Example jar has invalid main class #201

p013570 opened this issue May 12, 2016 · 2 comments
Labels
bug Confirmed or suspected bug
Milestone

Comments

@p013570
Copy link
Member

p013570 commented May 12, 2016

This was introduced by issue gh-14 when packages were renamed.

We should probably just remove the main class and allow users to chose which example class to run on the command line.

@p013570 p013570 added bug Confirmed or suspected bug p:high labels May 12, 2016
@p013570 p013570 added this to the v0.3.5 milestone May 12, 2016
p013570 added a commit that referenced this issue May 12, 2016
This means any of the examples can be run by supplying the class name on the command line, e.g:
java -cp example-jar-with-dependencies.jar gaffer.example.gettingstarted.analytic.LoadAndQuery1
@p013570
Copy link
Member Author

p013570 commented May 12, 2016

Migration Steps

To run the examples on the command line you now need to specify which example to run by providing the class name as an argument and using 'java -cp' instead of 'java -jar'

java -cp example-jar-with-dependencies.jar gaffer.example.gettingstarted.analytic.LoadAndQuery1

a09631 added a commit that referenced this issue May 12, 2016
-example-jar

gh-201 - removed main class from example jar manifest
@a09631
Copy link
Contributor

a09631 commented May 12, 2016

Pull request approved and merged in to release-0.3.5 branch.

@a09631 a09631 closed this as completed May 12, 2016
c015dariu pushed a commit to c015dariu/Gaffer that referenced this issue Jul 11, 2019
c015dariu pushed a commit to c015dariu/Gaffer that referenced this issue Jul 11, 2019
c015dariu pushed a commit to c015dariu/Gaffer that referenced this issue Jul 11, 2019
c015dariu pushed a commit to c015dariu/Gaffer that referenced this issue Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug
Projects
None yet
Development

No branches or pull requests

2 participants