Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FederatedStore GetTraits audit #2455

Closed
GCHQDev404 opened this issue Jul 1, 2021 · 0 comments · Fixed by #2456
Closed

FederatedStore GetTraits audit #2455

GCHQDev404 opened this issue Jul 1, 2021 · 0 comments · Fixed by #2456
Assignees
@GCHQDev404

Comments

@GCHQDev404
Copy link
Contributor

Removing Dead code not accessible via executing operations
Auditing tests
Auditing behaviours
@GCHQDev404 GCHQDev404 self-assigned this Jul 1, 2021
@GCHQDev404 GCHQDev404 changed the title FederatedStore GetTraitsOperation audit FederatedStore GetTraits audit Jul 1, 2021
GCHQDev404 added a commit that referenced this issue Jul 1, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Removing dead code and correc…
57840ad 
…ting tests and behaviours.
@github-actions github-actions bot mentioned this issue Jul 1, 2021
Merged
GCHQDev404 added a commit that referenced this issue Jul 1, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Removing dead code and correc…
7f476b5 
…ting tests and behaviours.
GCHQDev404 added a commit that referenced this issue Jul 1, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Removing dead code and correc…
4e89c31 
…ting tests and behaviours.
GCHQDev404 added a commit that referenced this issue Jul 1, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Removing dead code and correc…
5835e36 
…ting tests and behaviours.
GCHQDev404 added a commit that referenced this issue Jul 1, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Removing dead code and correc…
10ac4fb 
…ting tests and behaviours.
GCHQDev404 added a commit that referenced this issue Jul 1, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Removing dead code and correc…
f64d126 
…ting tests and behaviours.
GCHQDev404 added a commit that referenced this issue Jul 5, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Refactoring FederatedGetTrait…
c8e91ea 
…sHandler to use FederatedChain. Deprecating Store.getTraits() FederatedGraphStorage.getTraits
GCHQDev404 added a commit that referenced this issue Jul 5, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Refactoring FederatedGetTrait…
b1cc103 
…sHandler to use FederatedChain. Deprecating Store.getTraits() FederatedGraphStorage.getTraits
GCHQDev404 added a commit that referenced this issue Jul 5, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Refactoring FederatedGetTrait…
e14089e 
…sHandler to use FederatedChain. Deprecating Store.getTraits() FederatedGraphStorage.getTraits
GCHQDev404 added a commit that referenced this issue Jul 5, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Refactoring FederatedGetTrait…
15de583 
…sHandler to use FederatedChain. Deprecating Store.getTraits() FederatedGraphStorage.getTraits
GCHQDev404 added a commit that referenced this issue Jul 6, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Refactoring FederatedGetTrait…
ed912c8 
…sHandler to use FederatedChain. Fixing graphSizeCount.
GCHQDev404 added a commit that referenced this issue Jul 6, 2021
@GCHQDev404
Merge branch 'gh-2455-FederatedStore-getTraits-audit' into gh-2357-fe…
1d2f4b1 
…deratedstore-federated-operation

# Conflicts:
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorage.java
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedStore.java
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/impl/FederatedGetTraitsHandler.java
#	store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorageTest.java
#	store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/impl/FederatedGetTraitsHandlerTest.java
GCHQDev404 added a commit that referenced this issue Jul 6, 2021
@GCHQDev404
Merge branch 'gh-2455-FederatedStore-getTraits-audit' into gh-2357-fe…
687c293 
…deratedstore-federated-operation

# Conflicts:
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/impl/FederatedGetTraitsHandler.java
GCHQDev404 added a commit that referenced this issue Jul 6, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Refactoring
9c9ff98
GCHQDev404 added a commit that referenced this issue Jul 6, 2021
@GCHQDev404
gh-2455 FederatedStore GetTraits Audit. Removing dead code and correc… (
b22d7a7 
#2456)

* gh-2455 FederatedStore GetTraits Audit. Removing dead code and correcting tests and behaviours.

* gh-2455 FederatedStore GetTraits Audit. Refactoring FederatedGetTraitsHandler to use FederatedChain. Deprecating Store.getTraits() FederatedGraphStorage.getTraits

Co-authored-by: GCHQDev404 <gchqdev404@users.noreply.github.com>
GCHQDev404 added a commit that referenced this issue Jul 26, 2021
@GCHQDev404
Merge remote-tracking branch 'origin/gh-2455-FederatedStore-getTraits…
f907085 
…-audit' into gh-2357-federatedstore-federated-operation

# Conflicts:
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/impl/FederatedGetTraitsHandler.java
GCHQDev404 added a commit that referenced this issue Oct 24, 2022
@GCHQDev404 @t92549 @GCHQDeveloper314
gh-2357 federatedstore federated operation merge into v2 alpha (#2769)
c1517b1 
* gh-2357 FederatedStore FederatedOperation Operation/Graph/Merge

* gh-2357 FederatedStore FederatedOperation Handlers

* gh-2357 FederatedStore FederatedOperation IFederationOperation, Handlers & Tests

* gh-2357 FederatedStore FederatedOperation FederatedStore

* gh-2357 FederatedStore FederatedOperation removal of option KEY_OPERATION_OPTIONS_GRAPH_IDS.

* gh-2357 FederatedStore FederatedOperation GetSchema & GetTraits Changes

* gh-2357 FederatedStore FederatedOperation IFederatedOperation

* gh-2357 FederatedStore FederatedOperation deletion of FederatedOperationChain

* gh-2357 FederatedStore FederatedOperation viewValidation

* gh-2357 FederatedStore FederatedOperation Merging of results

* gh-2357 FederatedStore FederatedOperation Tests, CodeStyle, Refactoring & Comments

* gh-2357 FederatedStore FederatedOperation.v02 Builder IO focus

* gh-2357 FederatedStore FederatedOperation.v02. Removing suspected unrequired tests.

* gh-2357 FederatedStore FederatedOperation.v02. Resolving TODOs

* gh-2357 FederatedStore FederatedOperation.v02. Removing overly constraining MIDPUT generic

* gh-2357 FederatedStore FederatedOperation.v02. Resolving TODOs

* gh-2357 FederatedStore FederatedOperation.v02. checkstyle

* gh-2357 FederatedStore FederatedOperation.v02. Resolving TODOs.

* gh-2357 FederatedStore FederatedOperation.v02 with errors

* gh-2357 FederatedStore FederatedOperation.v02 isRequestingAdmin added to IFederation

* gh-2357 FederatedStore FederatedOperation.v02 IFederation builder changes.

* gh-2357 FederatedStore FederatedOperation.v02 IFederation shallowClone changes.

* gh-2357 FederatedStore FederatedOperation.v02 IFederation userRequestingAdminUsage changes.

* gh-2357 FederatedStore FederatedOperation.v02 IFederation userRequestingAdminUsage rename.

* gh-2357 FederatedStore FederatedOperation.v02 bugfix.

* gh-2357 FederatedStore FederatedOperation.v02 removing TODOs.

* gh-2422 FederatedStore ChangeGraphId & ChangeGraphAccess update cache + Test

* gh-2357 FederatedStore FederatedOperation.v02 removing TODOs.

* gh-2357 FederatedStore FederatedOperation.v02 removing TODOs. BugHunt

* gh-2357 FederatedStore FederatedOperation.v02 removing TODOs.

* gh-2425 remove duplicate updateOperationInput

* gh-2357 FederatedStore FederatedOperation.v02 removing TODOs.

* gh-2357 FederatedStore FederatedOperation.v02 FederatedOperation is InputOutput

* gh-2357 FederatedStore FederatedOperation.v02 removing TODOs. BugHunt

* gh-2357 FederatedStore FederatedOperation.v02 FederatedOperation is InputOutput

* fixing bug

* gh-2357 FederatedStore FederatedOperation.v02 FederatedOperation is InputOutput

* gh-2357 FederatedStore FederatedOperation.v02 Error Returning AccumuloAllElementsRetriever

* gh-2357 FederatedStore FederatedOperation.v02 MASSIVE bug fix for IterableConcat use of ChainedIterable Constructor.

* gh-2357 FederatedStore FederatedOperation.v02 IterableConcat fixes

* gh-2357 FederatedStore FederatedOperation.v02 summary

* gh-2357 FederatedStore FederatedOperation.v02 ChainedIterable ported over from Koryphe.
BREAKING CHANGE for any ChainedIterable saved to disc/metal.

* gh-2357 FederatedStore FederatedOperation.v02 checkstyle

* gh-2357 FederatedStore FederatedOperation.v02 Traits

* gh-2455 FederatedStore GetTraits Audit. Removing dead code and correcting tests and behaviours.

* gh-2455 FederatedStore GetTraits Audit. Refactoring FederatedGetTraitsHandler to use FederatedChain. Deprecating Store.getTraits() FederatedGraphStorage.getTraits

* gh-2455 FederatedStore GetTraits Audit. Refactoring FederatedGetTraitsHandler to use FederatedChain. Fixing graphSizeCount.

* gh-2455 FederatedStore GetTraits Audit. Refactoring

* gh-2422 FederatedStore ChangeGraphId & ChangeGraphAccess recovery info.

* gh-2357 FederatedStore FederatedOperation.v02 GetSchema

* gh-2357 FederatedStore FederatedOperation.v02 TODOs

* gh-2357 FederatedStore FederatedOperation.v02 TODOs

* gh-2357 FederatedStore FederatedOperation.v02 TODOs

* gh-2357 FederatedStore FederatedOperation.v02 PR review

* gh-2357 FederatedStore FederatedOperation.v02 Demo fix

* gh-2357 FederatedStore FederatedOperation merge with Alpha1 fixes including a temporary class while Korphye is being released.

* gh-2357 FederatedStore checkstyle

* gh-2369 Remove ChainedIterable Gaffer duplicate

* gh-2369 Dependency upgrade Koryphe 2.2.0

* gh-2369 Deleting Duplicate Koryphe classes

* gh-2369 Deleting Duplicate Koryphe classes updating imports

* Updated Koryphe version to 2.2.0

* gh-2369 corrections

* gh-2369 corrections

* Fix copyright dates

* gh-2369 import fix

* gh-2357 spotless changes

* gh-2357 FederatedStore FederatedOperation merging.

* gh-2357 FederatedStore FederatedOperation temporary classes in lieu of Koryphe changes. see gh-272

* gh-2357 FederatedStore FederatedOperation javadoc

* gh-2357 FederatedStore FederatedOperation default merge function change.

* gh-2357 FederatedStore FederatedOperation FederatedOutputIterableHandler rename and change

* Updated Koryphe version to 2.3.0

* gh-2357 FederatedStore FederatedOperation default merge function change.

* gh-2357 FederatedStore FederatedOperation tidy

* gh-2357 FederatedStore FederatedOperation Test improvement

* gh-2357 FederatedStore deprecated

* gh-2357 FederatedStore checkstyle

* gh-2357 FederatedStore TDD DefaultMerge of GetElements with View Aggregation

* gh-2357 FederatedStore spotless

* gh-2357 FederatedStore DefaultMergeFunction from util.

* gh-2357 FederatedStore DefaultMergeFunction best efforts of concat.

* FederatedStore Alpha4 Team Review PR

* gh-2357 FederatedStore undoing changes out of scope of gh-2357

* gh-2357 FederatedStore spotless checkstyle

* gh-2357 FederatedStore undoing changes out of scope of gh-2357 and spotless checkstyle

* gh-2357 FederatedStore reviewing of Todos, graphIds as List not just CSV.

* gh-2357 FederatedStore reviewing of Todos

* PR merge hot fix

* PR merge hot fix

* PR hotfix formatting

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 PR changes.

* gh-2357 Remove ToIterable, fix bracket typo

* gh-2357 PR changes.

* gh-2357 Fix regex

Co-authored-by: GCHQDev404 <gchqdev404@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDev404 GCHQDev404

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-2455 FederatedStore GetTraits Audit. Removing dead code and correc… gchq/Gaffer
1 participant
@GCHQDev404