Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate replacing java.util.logging.Logger with SLF4J #2662

Closed
n3101 opened this issue May 31, 2022 · 2 comments · Fixed by #2663
Closed

Investigate replacing java.util.logging.Logger with SLF4J #2662

n3101 opened this issue May 31, 2022 · 2 comments · Fixed by #2663
Labels
dependencies Updates/changes to Maven or other dependencies enhancement Improvement to existing functionality/feature tech-debt Relates to Technical Debt
Milestone
v1.23.0

Comments

@n3101
Copy link

n3101 commented May 31, 2022

@GCHQDeveloper314 noted that Gaffer mostly uses SLF4J to perform logging; except for the Road Traffic data example which uses java.util.logging.Logger. Investigate changing this to SLF4J to standardise our code. Check there are no similar anomalies elsewhere in the codebase.
@n3101 n3101 added this to the v2_backlog milestone Jun 1, 2022
@RobertG111
Copy link
Contributor

RobertG111 commented Jun 2, 2022 •
edited

Hi. I have made a pull request regarding this issue #2663. Thanks

@t92549 t92549 linked a pull request Jun 6, 2022 that will close this issue
gh-2662: Investigate replacing java.util.logging.Logger with SLF4J #2663
Merged
@t92549
Copy link
Contributor

t92549 commented Jun 6, 2022

Closed by #2663

@t92549 t92549 closed this as completed Jun 6, 2022
@t92549 t92549 modified the milestones: v2_backlog, v1.23.0 Jun 6, 2022
@t92549 t92549 added tech-debt Relates to Technical Debt dependencies Updates/changes to Maven or other dependencies enhancement Improvement to existing functionality/feature labels Jun 6, 2022
@t92549 t92549 mentioned this issue Jun 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Updates/changes to Maven or other dependencies enhancement Improvement to existing functionality/feature tech-debt Relates to Technical Debt
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging a pull request may close this issue.

gh-2662: Investigate replacing java.util.logging.Logger with SLF4J
3 participants
@RobertG111 @n3101 @t92549