Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring-rest api and swagger broken in alpha 2 #2665

Closed
t92549 opened this issue Jun 6, 2022 · 2 comments · Fixed by #2668
Closed

spring-rest api and swagger broken in alpha 2 #2665

t92549 opened this issue Jun 6, 2022 · 2 comments · Fixed by #2668
Assignees
@GCHQDeveloper314
Labels
bug Confirmed or suspected bug rest-api Specific to/touches a part of the REST API
Milestone
v2.0.0-alpha-0.3

Comments

@t92549
Copy link
Contributor

t92549 commented Jun 6, 2022

Despite the tests passing, the spring-rest does not work with the dependency upgrades.
@t92549 t92549 added bug Confirmed or suspected bug p:high rest-api Specific to/touches a part of the REST API labels Jun 6, 2022
@t92549 t92549 added this to the v2.0.0-alpha-0.3 milestone Jun 6, 2022
@github-actions github-actions bot mentioned this issue Jun 7, 2022
Merged
@GCHQDeveloper314 GCHQDeveloper314 linked a pull request Jun 7, 2022 that will close this issue
Gh-2665: Fix spring rest context-path & swagger UI #2668
Merged
@t92549
Copy link
Contributor Author

t92549 commented Jun 7, 2022

As well as spring-rest not actually running, it seems that the swagger does not work either

@t92549 t92549 changed the title spring-rest broken in alpha 2 spring-rest api and swagger broken in alpha 2 Jun 7, 2022
t92549 pushed a commit that referenced this issue Jun 8, 2022
@GCHQDeveloper314
Gh-2665: Fix spring rest context-path & swagger UI (#2668)
f70e5e8 
* Update configuration files to use 'server.servlet.context-path' as required by Spring
This change is required as 'server.context-path' is no longer valid in Spring Boot 2.x

* Update README to reflect Spring Boot 2.x changes

* Update IT to use renamed config value

* Replace springfox with springdoc
springfox is no longer supported or updated and version 3.0.0 wasn't working. springdoc offers better fuctionality with less boilerplate code. Swagger UI is now working.

* Configure Swagger UI style/layout, add endpoint name as tag shown in UI - replacing default of full classname

* Copyright Update

* Revert use of full classname where it wasn't required
@t92549
Copy link
Contributor Author

t92549 commented Jun 8, 2022

Fixed by #2668

@t92549 t92549 closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDeveloper314 GCHQDeveloper314

Labels
bug Confirmed or suspected bug rest-api Specific to/touches a part of the REST API
Projects
None yet
Milestone
v2.0.0-alpha-0.3
Development

Successfully merging a pull request may close this issue.

Gh-2665: Fix spring rest context-path & swagger UI gchq/Gaffer
2 participants
@t92549 @GCHQDeveloper314