Fix FederatedStore cache collision #2903

GCHQDev404 · 2023-02-23T11:09:40Z

Describe the bug
When using the same cache implementation in a FederatedStore, the caches will collide.

To Reproduce

Create a FederatedStore
Add GraphA with a cache
Add GraphB with a cache (same cache implementation)
Add a NamedOperation to GraphA (NamedOperations are stored in the cache)
List NamedOperations in GraphB - it will be visibile even though it should not be

Suggested solution
All graphs require suffix usage, similar to FederatedGraphStroage Cache.

…tructor.

… in return object?

…ithout AddView and AddNamedOperations.

… be able to add a Proxy Store with or without AddView and AddNamedOperations.

…ithin-a-federatedstore-environment' into gh-2903-part2 # Conflicts: # store-implementation/proxy-store/src/main/java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java

…ithin-a-federatedstore-environment' into gh-2903-part2 # Conflicts: # store-implementation/proxy-store/src/test/java/uk/gov/gchq/gaffer/proxystore/integration/ProxyStoreResponseDeserialiserIT.java

…ithin-a-federatedstore-environment' into gh-2906-federatedstore-removegraph-must-clear-all-associated-caches

…-collision' into gh-2903-all-caches-require-suffix-to-avoid-collisions-within-a-federatedstore-environment # Conflicts: # store-implementation/proxy-store/src/main/java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java

…-collision' into gh-2903-all-caches-require-suffix-to-avoid-collisions-within-a-federatedstore-environment

…ithin-a-federatedstore-environment' into gh-2903-part2 # Conflicts: # store-implementation/proxy-store/src/main/java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java # store-implementation/proxy-store/src/test/java/uk/gov/gchq/gaffer/proxystore/integration/ProxyStoreResponseDeserialiserIT.java

…h-2903-return-proxy-store-to-no-cache-handlers # Conflicts: # core/store/src/main/java/uk/gov/gchq/gaffer/store/Store.java

…oxy-store-to-no-cache-handlers # Conflicts: # core/graph/src/test/java/uk/gov/gchq/gaffer/graph/GraphTest.java # store-implementation/proxy-store/src/main/java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java # store-implementation/proxy-store/src/test/java/uk/gov/gchq/gaffer/proxystore/integration/ProxyStoreResponseDeserialiserIT.java

…h-2903-new-proxy-IT-test

…2912) * gh-2886 FederatedStore remove double caching accidental collision. * gh-2887 Test fixed to user correct cache instance due to suffix/name change. * gh-2903 All Cache requires suffix * gh-2903 Test changes for Cache requiring suffix * gh-2903 Cherry Picked, improvements. * gh-2903 test fix * gh-2903 tidy. * gh-2886 PR change * gh-2886 review * gh-2903 PR changes. * gh-2903 PR changes. * gh-2906 RemoveGraph to optionally delete Caches. * gh-2906 spotless. * gh-2909 duplication * gh-2906 PR changes. --------- Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>

* gh-2886 FederatedStore remove double caching accidental collision. * gh-2886 FederatedStore remove double caching accidental collision. * gh-2887 Test fixed to user correct cache instance due to suffix/name change. * gh-2903 removing 1.12 cache tests and graphStorage zero argument constructor. * gh-2903 All Cache requires suffix * gh-2903 Test changes for Cache requiring suffix * gh-2903 spotless * gh-2903 Cherry Picked, improvements. * gh-2903 test fix * gh-2903 test fix * gh-2886 PR change * gh-2903 tidy. * gh-2886 review * gh-2886 PR request * gh-2886 PR request * gh-2903 merge conflicts * gh-2903 PR changes. * gh-2903 PR changes. * gh-2903 PR changes. * gh-2903 PR changes. * gh-2903 Cache changes for Score Resolvers. * gh-2903 Cache changes for Score Resolvers. * gh-2903 spotless * gh-2909 AddGraph with Handlers. * gh-2909 merge * gh-2903 spotless * gh-2909 improved getting operation declarations json * gh-2909 duplication * gh-2909 PR changes. --------- Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>

…oxy-store-to-no-cache-handlers # Conflicts: # store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/impl/FederatedAddGraphHandlerTest.java

…h-2903-new-proxy-IT-test

t92549 · 2023-04-11T14:11:06Z

Closed by #2907

* gh-2903 Cache changes for Score Resolvers. * gh-2903 spotless * gh-2903 Proxy stripped of unnessary Handlers and hooks, but exception in return object? * gh-2903 FederatedStore need to be able to add a Proxy Store with or without AddView and AddNamedOperations. * gh-2903 duplicate ProxyStore as alternative to FederatedStore need to be able to add a Proxy Store with or without AddView and AddNamedOperations. * gh-2903 Removing duplicate ProxyStore with Cache Handlers. instead IT with configured CacheHandlers. * Fixed ProxyStoreWithNamedOpNamedViewITs * Fixed new ProxyStoreWithNamedOpNamedViewITs class * Fix ProxyStore NamedOp deserialisation * Fix checkstyle --------- Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com> Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>

GCHQDev404 added the bug Confirmed or suspected bug label Feb 23, 2023

GCHQDev404 added this to the v2.0.0-alpha-0.6 milestone Feb 23, 2023

GCHQDev404 added a commit that referenced this issue Feb 23, 2023

gh-2903 removing 1.12 cache tests and graphStorage zero argument cons…

e0b8e5d

…tructor.

GCHQDev404 added a commit that referenced this issue Feb 23, 2023

gh-2903 All Cache requires suffix

6e96b81

GCHQDev404 linked a pull request Feb 23, 2023 that will close this issue

Gh 2903 all caches require suffix to avoid collisions within a federatedstore environment #2907

Merged

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 Test changes for Cache requiring suffix

d66a24b

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 spotless

b14e6c1

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 Proxy stripped of unnessary Handlers and hooks, but exception…

bbc89e0

… in return object?

github-actions bot mentioned this issue Feb 24, 2023

gh-2903 Return Proxy to being empty #2908

Closed

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 FederatedStore need to be able to ass a Proxy Store with or w…

0643cfe

…ithout AddView and AddNamedOperations.

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 FederatedStore need to be able to add a Proxy Store with or w…

3720de2

…ithout AddView and AddNamedOperations.

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 duplicate ProxyStore as alternative to FederatedStore need to…

3488e26

… be able to add a Proxy Store with or without AddView and AddNamedOperations.

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 duplicate ProxyStore as alternative to FederatedStore need to…

b1c33e5

… be able to add a Proxy Store with or without AddView and AddNamedOperations.

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 duplicate ProxyStore as alternative to FederatedStore need to…

6a1371c

… be able to add a Proxy Store with or without AddView and AddNamedOperations.

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 duplicate ProxyStore as alternative to FederatedStore need to…

549d23b

… be able to add a Proxy Store with or without AddView and AddNamedOperations.

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 Cherry Picked, improvements.

1fafffd

GCHQDev404 linked a pull request Feb 24, 2023 that will close this issue

gh-2903 Return Proxy to being empty #2908

Closed

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 test fix

b4c3eb0

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 test fix

f624a81

GCHQDev404 added a commit that referenced this issue Feb 24, 2023

gh-2903 test fix

63c239e

GCHQDev404 added a commit that referenced this issue Feb 28, 2023

gh-2903 tidy.

0f232cf

GCHQDev404 added a commit that referenced this issue Feb 28, 2023

Merge branch 'gh-2903-all-caches-require-suffix-to-avoid-collisions-w…

b86fad4

…ithin-a-federatedstore-environment' into gh-2906-federatedstore-removegraph-must-clear-all-associated-caches

GCHQDev404 added a commit that referenced this issue Mar 1, 2023

gh-2903 merge conflicts

ce58531

GCHQDev404 added a commit that referenced this issue Mar 1, 2023

Merge branch 'gh-2886-FederatedStore-Double-cache-removing-accidental…

d98f9eb

…-collision' into gh-2903-all-caches-require-suffix-to-avoid-collisions-within-a-federatedstore-environment

github-actions bot mentioned this issue Mar 1, 2023

Gh 2903 return proxy store to no cache handlers #2916

Closed

GCHQDev404 added a commit that referenced this issue Mar 2, 2023

Merge branch '2909-federatedstore-to-add-graphs-with-handlers' into g…

1f42219

…h-2903-return-proxy-store-to-no-cache-handlers # Conflicts: # core/store/src/main/java/uk/gov/gchq/gaffer/store/Store.java

GCHQDev404 added a commit that referenced this issue Mar 3, 2023

gh-2903 PR changes.

4328788

GCHQDev404 added a commit that referenced this issue Mar 3, 2023

Merge branch 'gh-2903-return-proxy-store-to-no-cache-handlers' into g…

8c33018

…h-2903-new-proxy-IT-test

GCHQDev404 added a commit that referenced this issue Mar 3, 2023

gh-2903 expected remote handlers.

f038786

GCHQDev404 added a commit that referenced this issue Mar 6, 2023

gh-2903 PR changes.

9ee38ac

GCHQDev404 added a commit that referenced this issue Mar 6, 2023

Merge branch 'gh-2903-return-proxy-store-to-no-cache-handlers' into g…

a3337b7

…h-2903-new-proxy-IT-test

GCHQDev404 added a commit that referenced this issue Mar 6, 2023

Merge branch 'gh-2903-return-proxy-store-to-no-cache-handlers' into g…

912c4ba

…h-2903-new-proxy-IT-test

GCHQDev404 added a commit that referenced this issue Mar 6, 2023

gh-2903 Re-removing handlers.

7c2e1af

GCHQDev404 added a commit that referenced this issue Mar 6, 2023

gh-2903 Re-removing handlers.

01f91bd

GCHQDev404 added a commit that referenced this issue Mar 6, 2023

gh-2903 Re-removing handlers.

15dfc6c

GCHQDev404 added a commit that referenced this issue Mar 6, 2023

Merge branch 'gh-2903-return-proxy-store-to-no-cache-handlers' into g…

60b7733

…h-2903-new-proxy-IT-test

GCHQDev404 added a commit that referenced this issue Mar 6, 2023

gh-2903

ca96fd6

This was linked to pull requests Mar 7, 2023

Gh 2903 new proxy it test #2923

Merged

Gh 2903 return proxy store to no cache handlers #2921

Closed

GCHQDeveloper314 assigned GCHQDev404 Mar 23, 2023

t92549 added a commit that referenced this issue Mar 31, 2023

Merge branch 'v2-alpha' into gh-2903-new-proxy-IT-test

0cba4fc

t92549 assigned t92549 and unassigned GCHQDev404 Apr 11, 2023

t92549 removed a link to a pull request Apr 11, 2023

gh-2903 Return Proxy to being empty #2908

Closed

t92549 assigned GCHQDev404 and unassigned t92549 Apr 11, 2023

t92549 removed a link to a pull request Apr 11, 2023

Gh 2903 return proxy store to no cache handlers #2921

Closed

t92549 changed the title ~~All Caches require suffix to avoid collisions within a FederatedStore environment.~~ Fix FederatedStore cache collision Apr 11, 2023

t92549 closed this as completed Apr 11, 2023

t92549 removed a link to a pull request Apr 11, 2023

Gh 2903 new proxy it test #2923

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix FederatedStore cache collision #2903

Fix FederatedStore cache collision #2903

GCHQDev404 commented Feb 23, 2023 •

edited by t92549

Loading

t92549 commented Apr 11, 2023

Fix FederatedStore cache collision #2903

Fix FederatedStore cache collision #2903

Comments

GCHQDev404 commented Feb 23, 2023 • edited by t92549 Loading

t92549 commented Apr 11, 2023

GCHQDev404 commented Feb 23, 2023 •

edited by t92549

Loading