Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade JUnit and related dependencies and plugins #2948

Closed
GCHQDeveloper314 opened this issue May 12, 2023 · 0 comments · Fixed by #2976
Closed

Upgrade JUnit and related dependencies and plugins #2948

GCHQDeveloper314 opened this issue May 12, 2023 · 0 comments · Fixed by #2976
Assignees
@GCHQDeveloper314
Labels
dependencies Updates/changes to Maven or other dependencies enhancement Improvement to existing functionality/feature
Milestone
v2.1.0

Comments

@GCHQDeveloper314
Copy link
Member

Since the last work on dependencies, the Maven Surefire and Failsafe plugins have had major versions released. There have previously been bugs/problems with these plugins (e.g. #2850), hopefully these new versions will work correctly.

The versions for JUnit, JUnit Suites, AssertJ and Mockito can also be updated. However this is causing a runtime problem when testing.
With these versions:

<junit.version>5.9.2</junit.version>
<junit-suite.version>1.9.3</junit-suite.version>
<assertj.version>3.24.2</assertj.version>
<mockito.version>4.11.0</mockito.version>

The following problems occur when running mvn clean install -Pcoverage -pl :map-store:

[ERROR] uk.gov.gchq.gaffer.mapstore.optimiser.CountAllElementsOperationChainOptimiserTest.shouldReturnExpectedOptimisedOperationChain(OperationChain,OperationChain)  Time elapsed: 0.048 s  <<< ERROR!
java.lang.NoSuchMethodError: 'java.lang.String[] org.junit.platform.commons.util.ReflectionUtils.parseQualifiedMethodName(java.lang.String)'

[ERROR] uk.gov.gchq.gaffer.mapstore.optimiser.CountAllElementsOperationChainOptimiserTest.shouldNotOptimiseOperationChain(OperationChain)  Time elapsed: 0.052 s  <<< ERROR!
java.lang.NoSuchMethodError: 'java.lang.String[] org.junit.platform.commons.util.ReflectionUtils.parseQualifiedMethodName(java.lang.String)'
@GCHQDeveloper314 GCHQDeveloper314 added the dependencies Updates/changes to Maven or other dependencies label May 12, 2023
@GCHQDeveloper314 GCHQDeveloper314 added this to the post-v2.0_backlog milestone May 12, 2023
@t92549 t92549 modified the milestones: Backlog, v2.1.0 May 26, 2023
@GCHQDeveloper314 GCHQDeveloper314 self-assigned this Jun 13, 2023
@github-actions github-actions bot mentioned this issue Jun 13, 2023
Merged
GCHQDeveloper314 added a commit that referenced this issue Jun 20, 2023
@GCHQDeveloper314
Gh-2948: Upgrade JUnit and related dependencies and plugins (#2976)
76a3756 
* Bump versions of JUnit, JUnit Suites and AssertJ

* Bump Mockito version

* Bump Surefire and Failsafe plugins to latest versions
Also remove some redundant version specifications for these plugins

* Bump JaCoCo plugin to latest version
@t92549 t92549 added the enhancement Improvement to existing functionality/feature label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDeveloper314 GCHQDeveloper314

Labels
dependencies Updates/changes to Maven or other dependencies enhancement Improvement to existing functionality/feature
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Gh-2948: Upgrade JUnit and related dependencies and plugins gchq/Gaffer
2 participants
@t92549 @GCHQDeveloper314