Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inV() and outV() not supported on GafferPopEdges #3219

Closed
cn337131 opened this issue May 20, 2024 · 0 comments · Fixed by #3221
Closed

inV() and outV() not supported on GafferPopEdges #3219

cn337131 opened this issue May 20, 2024 · 0 comments · Fixed by #3221
Assignees
@cn337131
Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.2.2

Comments

@cn337131
Copy link
Member

Describe the bug
Currently a default label will be used if a vertex IDs are used to construct a new edge or if asking for the in/out vertex on the edge. This may result in an incorrect mapping of a Tinkerpop 'label' to a Gaffer 'group', meaning the GafferPopVertex returned by the 'getOutVertex()' and 'getInVertex()' methods likely does not have the correct 'label'.

This is likely due to Gaffer allowing multiple entities/vertexes to be associated with the source and destination vertices of an Edge whereas, Tinkerpop only expects one out vertex and one in vertex on the edge, and hence the 'getOutVertex()' and 'getInVertex()' methods are expected to be used and are part of the interface.

One solution is that a search could be carried out to determine the correct Entity to use when a vertex ID is supplied to an edge, his may hamper performance though, this ticket is to investigate if this is a feature we want to support and the impact of not supporting it.
@cn337131 cn337131 added bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module labels May 20, 2024
@cn337131 cn337131 self-assigned this May 20, 2024
cn337131 added a commit that referenced this issue May 21, 2024
@cn337131
Merge branch 'develop' into gh-3219-fix-inV-outV-bug
e53ec43
@github-actions github-actions bot mentioned this issue May 22, 2024
Merged
tb06904 added a commit that referenced this issue May 23, 2024
@tb06904
Merge branch 'develop' into gh-3219-fix-inV-outV-bug
586fa54
tb06904 added a commit that referenced this issue May 28, 2024
@tb06904
Merge branch 'develop' into gh-3219-fix-inV-outV-bug
adbb9b3
tb06904 added a commit that referenced this issue May 29, 2024
@tb06904
Merge branch 'develop' into gh-3219-fix-inV-outV-bug
7c6570b
GCHQDeveloper314 pushed a commit that referenced this issue May 29, 2024
@cn337131
Gh-3219: Fix inV() and outV() missing results (#3221)
8df736a 
* fix for inV and outV, plus test fixes

* fix logic and tests

* added a view
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.3.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cn337131 cn337131

Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging a pull request may close this issue.

Gh-3219: Fix inV() and outV() missing results gchq/Gaffer
2 participants
@GCHQDeveloper314 @cn337131