Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement target delete for Map Store #3237

Closed
p29876 opened this issue Jun 13, 2024 · 0 comments · Fixed by #3239
Closed

Implement target delete for Map Store #3237

p29876 opened this issue Jun 13, 2024 · 0 comments · Fixed by #3239
Assignees
@p29876
Labels
feature A proposed new feature map-store Specific to/touches the map-store module
Milestone
v2.3.0

Comments

@p29876
Copy link
Member

p29876 commented Jun 13, 2024 •
edited
Loading

Add a Delete Elements Operation proof of concept to the Map Store.
@p29876 p29876 added map-store Specific to/touches the map-store module feature A proposed new feature labels Jun 13, 2024
@p29876 p29876 self-assigned this Jun 13, 2024
p29876 added a commit that referenced this issue Jun 13, 2024
@p29876
Gh-3237 Implement DeleteElements for Map Store
803cd8b
@github-actions github-actions bot mentioned this issue Jun 13, 2024
Merged
@tb06904 tb06904 added this to the v2.2.2 milestone Jun 19, 2024
tb06904 added a commit that referenced this issue Jun 20, 2024
@tb06904
Merge branch 'develop' into gh-3237-target-delete-map-store
f73b952
@tb06904 tb06904 removed this from the v2.2.2 milestone Jun 21, 2024
tb06904 added a commit that referenced this issue Jun 24, 2024
@tb06904
Merge branch 'develop' into gh-3237-target-delete-map-store
aff204c
cn337131 added a commit that referenced this issue Jul 1, 2024
@cn337131
Merge branch 'develop' into gh-3237-target-delete-map-store
7790adf
tb06904 added a commit that referenced this issue Jul 10, 2024
@tb06904
Merge branch 'develop' into gh-3237-target-delete-map-store
1fed27b
wb36499 pushed a commit that referenced this issue Jul 10, 2024
@p29876 @cn337131 @tb06904
Gh-3237 Implement DeleteElements for Map Store (#3239)
cda4cdd 
* Gh-3237 Implement DeleteElements for Map Store

* remove unused param

* spotless

* codecov and sonarcloud

* improve codecov and sonarcloud

* reduce test duplication and add to federated store

* checkstyle

* remove unused properties and improve check

* address PR comments and improve tests

* fix indent

* checkstyle

* copyright

* bump version

* address comments

* add comment

---------

Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com>
Co-authored-by: tb06904 <141412860+tb06904@users.noreply.github.com>
@cn337131 cn337131 added this to the v2.3.0 milestone Jul 12, 2024
wb36499 pushed a commit that referenced this issue Jul 16, 2024
@p29876 @cn337131
Gh-3238: target delete accumulo (#3249)
717f544 
* Gh-3237 Implement DeleteElements for Map Store

* remove unused param

* spotless

* wip

* finish

* checkstyle

* codecov and sonarcloud

* improve codecov and sonarcloud

* reduce test duplication and add to federated store

* checkstyle

* remove unused properties and improve check

* Gh-3238 Implement DeleteElements for Accumulo

* add accumulo test to federated store

* remove commented test

* address comments

* address comments

* checkstyle

* checkstyle

* headers

* code cov

* remove public

* remove AccumuloClient

* code cov

* checkystle

* add test

---------

Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p29876 p29876

Labels
feature A proposed new feature map-store Specific to/touches the map-store module
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging a pull request may close this issue.

Gh-3237 Implement DeleteElements for Map Store gchq/Gaffer
3 participants
@tb06904 @cn337131 @p29876