Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 1422 swagger ui configurable title #1494

Merged
merged 11 commits into from Nov 6, 2017

Conversation

m55624
Copy link
Contributor

@m55624 m55624 commented Nov 6, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 6, 2017

Codecov Report

Merging #1494 into develop will increase coverage by 0.03%.
The diff coverage is 96.77%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1494      +/-   ##
=============================================
+ Coverage       66.3%   66.33%   +0.03%     
+ Complexity      1749     1748       -1     
=============================================
  Files            727      727              
  Lines          23911    23933      +22     
  Branches        3084     3087       +3     
=============================================
+ Hits           15854    15876      +22     
  Misses          6793     6793              
  Partials        1264     1264
Impacted Files Coverage Δ Complexity Δ
...n/java/uk/gov/gchq/gaffer/rest/SystemProperty.java 60% <ø> (ø) 0 <0> (ø) ⬇️
...java/uk/gov/gchq/gaffer/rest/ServiceConstants.java 60% <ø> (ø) 0 <0> (ø) ⬇️
...hq/gaffer/rest/service/v2/PropertiesServiceV2.java 97.29% <96.77%> (+17.29%) 0 <0> (ø) ⬇️
...onutil/iterable/LimitedInMemorySortedIterable.java 47.22% <0%> (-2.78%) 15% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7629db2...63f9342. Read the comment docs.

@p013570 p013570 force-pushed the gh-1422-swagger-ui-configurable-title branch from fe07662 to 0e03ee2 Compare November 6, 2017 11:58
Copy link
Member

@p013570 p013570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some optimisations - please can you check you are happy with them.

@p013570 p013570 merged commit a57ab41 into develop Nov 6, 2017
@p013570 p013570 deleted the gh-1422-swagger-ui-configurable-title branch November 6, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants